[GitHub] [libcloud] Kami edited a comment on issue #1407: new driver: Kamatera

[GitBox <gi...@apache.org>]

Kami edited a comment on issue #1407: new driver: Kamatera
URL: https://github.com/apache/libcloud/issues/1407#issuecomment-574001587
 
 
   I think best approach would be to utilize option 1) in combination with allowing the user to specify a custom size by instantiating ``NodeImage`` class with custom values.
   
   Here is an example of a driver which does that - https://libcloud.readthedocs.io/en/stable/compute/drivers/cloudsigma.html#create-a-server-using-a-custom-node-size
   
   For custom attributes which are not supported by the ``NodeImage`` class you either have a choice of utilizing ``NodeImage`` class directly and putting custom attributes into ``extra`` directory or by subclassing it.
   
   Utilizing ``NodeImage`` directly is preferred over custom sub-class (especially if other custom attributes are optional - this way it still works out of the box with "standard" NodeImage class instances).
   
   ----
   
   EDIT: And where it makes sense and it's also applicable to other drivers / providers, we could perhaps also add some new standard attributes to the base / standard ``NodeImage`` class.
   
   Things such as ``disk_type`` (hdd, ssd, etc.) come to mind.
   
   Original ``NodeImage`` class implementation is quite old now and at that time providers didn't support things such as different disk types so it might make sense to extend it (and for backward compatibility reasons, we can default to ``hdd``).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services