You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "GenerousMan (via GitHub)" <gi...@apache.org> on 2023/07/11 06:35:14 UTC
[GitHub] [rocketmq] GenerousMan opened a new pull request, #7014: [ISSUE #7013]polish ColdDataCheckService's logic
GenerousMan opened a new pull request, #7014:
URL: https://github.com/apache/rocketmq/pull/7014
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7013
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #7014: [ISSUE #7013]polish ColdDataCheckService's logic
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on code in PR #7014:
URL: https://github.com/apache/rocketmq/pull/7014#discussion_r1259267020
##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -2089,6 +2089,16 @@ public void run() {
} else {
this.waitForRunning(defaultMessageStore.getMessageStoreConfig().getTimerColdDataCheckIntervalMs());
}
+
+ if (pageSize < 0) {
+ try {
+ initPageSize();
+ } catch (Exception e) {
+ log.error("Before scanning files in pagecache, initing has failed.", e);
+ return;
+ }
Review Comment:
这里无法抓住java.lang.UnsatisfiedLinkError
##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -2089,6 +2089,16 @@ public void run() {
} else {
this.waitForRunning(defaultMessageStore.getMessageStoreConfig().getTimerColdDataCheckIntervalMs());
}
+
+ if (pageSize < 0) {
+ try {
+ initPageSize();
+ } catch (Exception e) {
+ log.error("Before scanning files in pagecache, initing has failed.", e);
+ return;
+ }
Review Comment:
这里无法抓住java.lang.UnsatisfiedLinkError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #7014: [ISSUE #7013]polish ColdDataCheckService's logic
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7014:
URL: https://github.com/apache/rocketmq/pull/7014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org