You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2005/01/16 17:54:45 UTC

Re: svn commit: r12748 - trunk/subversion/bindings/java/javahl/native

pmayweg@tigris.org writes:

> Author: pmayweg
> Date: Sun Jan 16 10:43:15 2005
> New Revision: 12748
  
> -    std::string value = ltoa(sb.min_rev, JNIUtil::getFormatBuffer(), 10);
> +    std::ostringstream value;
> +    value << sb.min_rev;std::string;

That std::string doesn't look right.

>      if (sb.min_rev != sb.max_rev)
>      {
> -        value + ":";
> -        value += ltoa(sb.max_rev, JNIUtil::getFormatBuffer(), 10);
> +        value << ":";
> +        value << sb.max_rev;
>      }
>      if (sb.modified)
> -        value += "M";
> +        value << "M";
>      if (sb.switched)
> -        value += "S";
> +        value << "S";
>  
> -    return JNIUtil::makeJString(value.c_str());
> +    return JNIUtil::makeJString(value.str().c_str());
>  }
>  
>  jobjectArray SVNClient::revProperties(jobject jthis, const char *path, 

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org