You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/18 15:33:52 UTC

[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1338: Add file stats range optimizations for DeleteFileIndex

aokolnychyi commented on a change in pull request #1338:
URL: https://github.com/apache/iceberg/pull/1338#discussion_r472288740



##########
File path: api/src/main/java/org/apache/iceberg/data/Record.java
##########
@@ -35,4 +36,26 @@
   Record copy();
 
   Record copy(Map<String, Object> overwriteValues);
+
+  default Record copy(String field, Object value) {
+    Map<String, Object> overwriteValues = Maps.newHashMapWithExpectedSize(1);
+    overwriteValues.put(field, value);
+    return copy(overwriteValues);
+  }
+
+  default Record copy(String field1, Object value1, String field2, Object value2) {
+    Map<String, Object> overwriteValues = Maps.newHashMapWithExpectedSize(1);

Review comment:
       nit: why expected size is 1?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org