You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2023/09/27 07:03:37 UTC
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20513
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
IMPALA-12469: Allow short if statements on a single line in clang-format
This change allows short if statements and blocks to be put on a single
line, clang-format will keep these constructions as-is.
Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
---
M .clang-format
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/20513/1
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 11:01:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
IMPALA-12469: Allow short if statements on a single line in clang-format
This change allows short if statements and blocks to be put on a single
line, clang-format will keep these constructions as-is.
Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Reviewed-on: http://gerrit.cloudera.org:8080/20513
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Tamas Mate <tm...@apache.org>
Tested-by: Tamas Mate <tm...@apache.org>
---
M .clang-format
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Daniel Becker: Looks good to me, but someone else must approve
Tamas Mate: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has removed a vote on this change.
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20513/1/.clang-format
File .clang-format:
http://gerrit.cloudera.org:8080/#/c/20513/1/.clang-format@30
PS1, Line 30: AllowShortIfStatementsOnASingleLine
> I might be missing something, but the allowed values in the doc differ:
These values are for LLVM 18.0.0, Impala is using an old version, 5.0.1
https://releases.llvm.org/5.0.1/tools/clang/docs/ClangFormatStyleOptions.html
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 12:39:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 02 Oct 2023 08:14:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9765/
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 17:56:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9765/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 13:28:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14088/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 07:30:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20513/1/.clang-format
File .clang-format:
http://gerrit.cloudera.org:8080/#/c/20513/1/.clang-format@30
PS1, Line 30: AllowShortIfStatementsOnASingleLine
I might be missing something, but the allowed values in the doc differ:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#allowshortifstatementsonasingleline
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 12:23:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12469: Allow short if statements on a single line in clang-format
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20513 )
Change subject: IMPALA-12469: Allow short if statements on a single line in clang-format
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
LGTM! Thanks Peter!
http://gerrit.cloudera.org:8080/#/c/20513/1/.clang-format
File .clang-format:
http://gerrit.cloudera.org:8080/#/c/20513/1/.clang-format@30
PS1, Line 30: AllowShortIfStatementsOnASingleLine
> These values are for LLVM 18.0.0, Impala is using an old version, 5.0.1
Ah, thanks for the clarification!
--
To view, visit http://gerrit.cloudera.org:8080/20513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Gerrit-Change-Number: 20513
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2023 13:27:45 +0000
Gerrit-HasComments: Yes