[GitHub] [systemds] mboehm7 commented on pull request #1382: Nbaches Parameter with modelAvg Optional Parameter

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #1382:
URL: https://github.com/apache/systemds/pull/1382#issuecomment-917213708


   LGTM - thanks @atefeh-asayesh for the extension of the parameter server. During the merge I mode the following changes:
   
   * Fixed the local paramserv worker which pulled and pushed at the same iteration (for all but the first), although it needs to push the iteration before it pulls a new model and then work with that for nbatches.
   * Fixed the federated paramserv implementation which did not update the model correctly under modelAvg (last model update missing, and outside computeGradientsForNBatches the returned model was assumed as gradients in an additional model update). The related changes also simplified some duplicated code.
   * Fixed the computation of numSetsPerEpocNbatches which due to integer division might have lost a few batches.
   * Removed unused nbatch member variables and test methods, fixed test methods which used the constructor name
   * Fixed the federated tests to use a longer wait time after the last worker to ensure everything is ready before the experiments start.
   * Fixed some minor formatting issues and warnings
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org