You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/25 03:28:55 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request, #777: Introduce doneCh for ack error
wolfstudy opened a new pull request, #777:
URL: https://github.com/apache/pulsar-client-go/pull/777
Signed-off-by: xiaolongran <xi...@tencent.com>
### Motivation
In #456, we support the error information that may occur when the Go SDK side processes the Ack Command, but there is a bug in this implementation. We do not wait for the error information to return directly, so the error obtained in the Ack interface will always be nil.
### Modifications
Introduce `doneCh` to wait for the information of ack error to return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #777: Introduce doneCh for ack error
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on PR #777:
URL: https://github.com/apache/pulsar-client-go/pull/777#issuecomment-1261672061
> hi @wolfstudy , what would happen if currently we don't wait for ACK but broker side failed to ack? If we get the error response how do we suppose to handle it?
Here we can look at two situations:
1. If the location of the ack error is an error in the Go SDK, then we can now catch the error and try to call the ack interface again
2. If the ack error information is returned by the Broker, it means that the Broker has an error in processing the ack, and we can also try to ack again, but in general, we may need to further confirm why the Broker side failed and whether it conforms to the predetermined logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #777: Introduce doneCh for ack error
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on PR #777:
URL: https://github.com/apache/pulsar-client-go/pull/777#issuecomment-1246182779
@freeznet PTAL thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] xiaofan-luan commented on pull request #777: Introduce doneCh for ack error
Posted by GitBox <gi...@apache.org>.
xiaofan-luan commented on PR #777:
URL: https://github.com/apache/pulsar-client-go/pull/777#issuecomment-1253240719
hi @wolfstudy , what would happen if currently we don't wait for ACK but broker side failed to ack?
If we get the error response how do we suppose to handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat merged pull request #777: Introduce doneCh for ack error
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #777:
URL: https://github.com/apache/pulsar-client-go/pull/777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org