You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/02/08 18:42:00 UTC
[GitHub] [jackrabbit-oak] jelmini opened a new pull request #486: OAK-9680 Add support for Azure SAS URIs to oak-segment-azure
jelmini opened a new pull request #486:
URL: https://github.com/apache/jackrabbit-oak/pull/486
Add support for SAS URIs to utility code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] jelmini commented on pull request #486: OAK-9680 Add support for Azure SAS URIs to oak-segment-azure
Posted by GitBox <gi...@apache.org>.
jelmini commented on pull request #486:
URL: https://github.com/apache/jackrabbit-oak/pull/486#issuecomment-1033997666
@smiroslav I had to introduce the `Environment` class to be able to test the code. Mockito cannot mock `System.getenv()` because it's a system class. Alternatively, it's possible to hack a workaround using reflection to obtain the underlying mutable Map from `System.getenv()`. This works with Java up until 15 with a big warning, but stops working from Java 16 forward (because "illegal reflective access" really becomes illegal).
Is there another approach for testing this code you could suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] smiroslav commented on pull request #486: OAK-9680 Add support for Azure SAS URIs to oak-segment-azure
Posted by GitBox <gi...@apache.org>.
smiroslav commented on pull request #486:
URL: https://github.com/apache/jackrabbit-oak/pull/486#issuecomment-1034750461
Thanks @jelmini for clarification. There are some test libraries that can inject values for system properties, but I like your approach better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] smiroslav commented on pull request #486: OAK-9680 Add support for Azure SAS URIs to oak-segment-azure
Posted by GitBox <gi...@apache.org>.
smiroslav commented on pull request #486:
URL: https://github.com/apache/jackrabbit-oak/pull/486#issuecomment-1033973655
Looks good to me.
As a minor comment, not sure that introducing Environment class brings obvious benefits right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] smiroslav merged pull request #486: OAK-9680 Add support for Azure SAS URIs to oak-segment-azure
Posted by GitBox <gi...@apache.org>.
smiroslav merged pull request #486:
URL: https://github.com/apache/jackrabbit-oak/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org