You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/10/06 22:10:27 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
brusdev opened a new pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290
The only executable included in the broker bin package that depends on .NET Framework 3.5 is artemis-service.exe/winsw. Using winsw for .NET Framework 4 we should remove any dependency on .NET Framework 3.5.
This would simplify the installation on Windows because .NET Framework 4 is installed by default on the last versions of Windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-725536528
If my understanding is correct this may break users running .NET Framework 3.5. If so I don't think we can do this in a minor release. I think we'd want to ship versions that work with either 3.5 or 4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev edited a comment on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
brusdev edited a comment on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-725534088
It will require .NET Framework 4 that is installed by default on the last versions of Windows while .NET Framework 3.5 not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-939890190
Assuming it works (not tried), if this is the desired approach then the changes seem reasonable based on reading the linked page. PR/Jira needs retitled though.
I think I would just require .Net 4 instead as originally intended though (with perhaps the -net3 fallback/duplicate I suggested earlier, but I no longer think its needed). There seems to be a version of .Net4 installed by default on every Windows released for about a decade, and its available to ones even older than that. At this point .Net 4 is so old even Microsooft's compatibility page above is noting they have dropped support for .Net 4 - 4.5.1 entirely from Visual Studio 2022.
There also seem to be [large] native exe versions of the service wrapper (based on .Net Core) that dont require any framework be installed, thus offering people another simple workaround (download+replace) if there are any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-921404782
@jbertram `artemis-service-net4.exe` LGTM, I'll update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-725534088
It will require .NET Framework 4 is installed by default on the last versions of Windows while .NET Framework 3.5 not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-921823519
If thats possible, great. I dont see a great need at this point personally. We are about to require a 4 year old JVM to run the broker...it doesnt seem unreasonable to require a ~10? year old version of .Net thats only optionally used to start/stop it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3290: ARTEMIS-2933 Add .NET Famework v4.0 supported runtime for com.sun.winsw
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-940073435
@jbertram @gemmellr thanks for your feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-725531157
Is this backwards compatible with 3.5? For example, if a user had .NET Framework 3.5 installed would the new winsw still work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-939808053
Adding the config file to support multiple .NET Framework runtimes works on WIndows 10 without .NET Framework 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev edited a comment on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
brusdev edited a comment on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-939808053
Adding a config file to support multiple .NET Framework runtimes works on WIndows 10 without .NET Framework 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-921615621
I would maybe avoid adding simply '-net4' in the name/patch at this point given 6 is already in RC phase?
The support pages https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/versions-and-dependencies suggest all versions of windows back to 8/server2012 have some .Net 4 framework version installed by default, and all versions back to 7/server2008 can get one if not installed.
Given that it doesnt seem unreasonable to require it at this point, so what about the reverse possibility? Make an alternative 'new' "-net3" version that ships for a limited time as a fallback option if we think it necessary (given above, I probably wouldnt), and then anyone actually affected by the change can use it instead if they dont want to use one of the many 4+ versions already available to them.
I wouldn't say dropping support of a .Net version in a minor release is all that different than dropping support of a Java version in a minor release, which has been done before and is about to be done again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev merged pull request #3290: ARTEMIS-2933 Add .NET Famework v4.0 supported runtime for com.sun.winsw
Posted by GitBox <gi...@apache.org>.
brusdev merged pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-921803809
@gemmellr I'm investigating on the possibility to run executable built for .NET 2 on .NET 4 using the `App.config file`
https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-configure-an-app-to-support-net-framework-4-or-4-5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-921314135
Perhaps the `pom.xml` could be modified so that 2 different versions of `artemis-service.exe` are created. The new one could have a new name to reflect its usage (e.g. `artemis-service-net4.exe` or perhaps with the same name but in a new `net4` directory) and the documentation could be updated accordingly (including deprecating the old one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3290: ARTEMIS-2933 Upgrade com.sun.winsw to 2.7.0-net4
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3290:
URL: https://github.com/apache/activemq-artemis/pull/3290#issuecomment-921681590
Given that last bit of my previous comment, maybe changing to requiring .Net 4 [by default, if also adding the fallback option] in the same release as changing to requiring Java 11 would be a nice alignment of support changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org