You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by mfranklin <gi...@git.apache.org> on 2014/07/30 15:55:54 UTC
[GitHub] incubator-streams pull request: Streams 135 | Remove active wait t...
GitHub user mfranklin opened a pull request:
https://github.com/apache/incubator-streams/pull/58
Streams 135 | Remove active wait that causes hight CPU utilization under no load
Tested against the full garden hose (no filters) for 30 min with no issues and with filters for 12 hours without issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-streams STREAMS-135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit ace69cf34f4561429b7ed3ab2402bc956bebe25e
Author: mfranklin <mf...@apache.org>
Date: 2014-07-29T22:04:26Z
STREAMS-135 | Refactored provider to be reactive and not spin lock
commit 28406d9c732e4871096606b95b71f86261cff31a
Author: mfranklin <mf...@apache.org>
Date: 2014-07-29T23:46:23Z
STREAMS-135 | Adjusted checks for config so that the sample endpoint can be used
commit 04054d43664267f51dda59996c8698a7c4a6e7c4
Author: mfranklin <mf...@apache.org>
Date: 2014-07-30T12:17:57Z
STREAMS-135 | Reduced number of serialization/deserialization steps
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 135 | Remove active wait t...
Posted by sieverssj <gi...@git.apache.org>.
Github user sieverssj commented on the pull request:
https://github.com/apache/incubator-streams/pull/58#issuecomment-50759037
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 135 | Remove active wait t...
Posted by sieverssj <gi...@git.apache.org>.
Github user sieverssj commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/58#discussion_r15585503
--- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterStreamProvider.java ---
@@ -226,20 +220,55 @@ else if( config.getEndpoint().endsWith("firehose")) {
.endpoint(endpoint)
.authentication(auth)
.connectionTimeout(1200000)
- .processor(new StringDelimitedProcessor(hosebirdQueue))
+ .processor(processor)
.build();
}
@Override
public void cleanUp() {
- for (int i = 0; i < 5; i++) {
- hosebirdQueue.add(TwitterEventProcessor.TERMINATE);
- }
+ this.client.stop();
+ this.processor.cleanUp();
+ this.running.set(true);
--- End diff --
Shouldn't this be set to false?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 135 | Remove active wait t...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/58#issuecomment-50755304
If there are no more issues, I will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 135 | Remove active wait t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---