You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2025/03/10 13:19:29 UTC
[I] Apply additional ruff suggestions [datafusion-python]
timsaucer opened a new issue, #1056:
URL: https://github.com/apache/datafusion-python/issues/1056
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
https://github.com/apache/datafusion-python/pull/1055 enabled most `ruff` rules, but became a very large PR. Many rules were just added to the ignore list in `pyproject.toml`. It would be good to enable all rules we can.
**Describe the solution you'd like**
We should go through these one by one and enable them and make the appropriate code improvements.
**Describe alternatives you've considered**
Leave as is.
**Additional context**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Apply additional ruff suggestions [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on issue #1056:
URL: https://github.com/apache/datafusion-python/issues/1056#issuecomment-2710916615
Certainly, but you probably want to wait until #1055 lands in `main` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Apply additional ruff suggestions [datafusion-python]
Posted by "Spaarsh (via GitHub)" <gi...@apache.org>.
Spaarsh commented on issue #1056:
URL: https://github.com/apache/datafusion-python/issues/1056#issuecomment-2722758168
Since #1055 has been merged, I have begun work on this on my fork [here](https://github.com/Spaarsh/datafusion-python/tree/1056/refactor/add-additional-ruff-suggestions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Apply additional ruff suggestions [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer closed issue #1056: Apply additional ruff suggestions
URL: https://github.com/apache/datafusion-python/issues/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Apply additional ruff suggestions [datafusion-python]
Posted by "Spaarsh (via GitHub)" <gi...@apache.org>.
Spaarsh commented on issue #1056:
URL: https://github.com/apache/datafusion-python/issues/1056#issuecomment-2710880413
Can I work on this? I've been going through the code base recently have and understand ruff rules as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Apply additional ruff suggestions [datafusion-python]
Posted by "Spaarsh (via GitHub)" <gi...@apache.org>.
Spaarsh commented on issue #1056:
URL: https://github.com/apache/datafusion-python/issues/1056#issuecomment-2710921582
Sure. I'll begin the work as soon as it is merged to ```main```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org