You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cuspymd <gi...@git.apache.org> on 2016/12/28 16:36:13 UTC
[GitHub] zeppelin pull request #1811: [MINOR] Fix paragraph id misalignment in dropdo...
GitHub user cuspymd opened a pull request:
https://github.com/apache/zeppelin/pull/1811
[MINOR] Fix paragraph id misalignment in dropdown menu
### What is this PR for?
Fix paragraph id misalignment in dropdown menu at Chrome/Firefox browser.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
N/A
### How should this be tested?
Open the dropdown menu of a paragraph at Chrome/Firefox browser.
### Screenshots (if appropriate)
* before
*after
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuspymd/zeppelin fix-dropdown-menu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1811.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1811
----
commit 0eb047c9e765f8bb0545b23e8e6db8c855285058
Author: Myoungdo Park <cu...@gmail.com>
Date: 2016-12-26T15:42:43Z
Fix paragraph id misalignment in dropdown menu
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1811
@cuspymd I tried to make the browser width narrower and tried to change the paragraph width itself , but still couldn't reproduce.
Am I missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1811: [MINOR] Fix paragraph id misalignment in dropdo...
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd closed the pull request at:
https://github.com/apache/zeppelin/pull/1811
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1811
@cuspymd Thanks. Let me try :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1811
I've checked it is resolved at latest commit.
Thanks for your check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1811
@cuspymd Could you resolve conflict and test again?
I think this problem is gone because this feature is changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1811
Thanks for your contribution. I added clipboard in #1750 but, can't reproduce the text overflow like you attached screenshot. I tested latest master in Chrome / Firefox / Safari.
- Chrome
<img width="329" alt="screen shot 2016-12-29 at 4 09 51 pm" src="https://cloud.githubusercontent.com/assets/10060731/21538539/77726244-cde1-11e6-80b3-120f91e4a329.png">
- Firefox
<img width="296" alt="screen shot 2016-12-29 at 4 12 13 pm" src="https://cloud.githubusercontent.com/assets/10060731/21538550/94c11aa2-cde1-11e6-86f0-a74dfcc6b803.png">
- Safari
<img width="292" alt="screen shot 2016-12-29 at 4 12 38 pm" src="https://cloud.githubusercontent.com/assets/10060731/21538555/a2e2a772-cde1-11e6-887b-e6b7f8fcba9c.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1811
Let's try to change the width of browser.
It is reprouced when the width of browser is narrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---