[GitHub] [apisix-dashboard] yangboyd opened a new pull request, #2564: upstream discovery allow server name pass from request host

[GitBox <gi...@apache.org>]

yangboyd opened a new pull request, #2564:
URL: https://github.com/apache/apisix-dashboard/pull/2564

   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   upstream discovery allow server name pass from request host
   add service_name_type field with value: pass, rewrite.
   The original service_name field is used as rewrite service name.
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2564: upstream discovery allow server name pass from request host

[GitBox <gi...@apache.org>]

bzp2010 commented on PR #2564:
URL: https://github.com/apache/apisix-dashboard/pull/2564#issuecomment-1203453766

   Hi, @yangboyd.
   
   I noticed that you updated `schema.json` and some Struct definitions which should not be modified manually, so I think this PR is inappropriate.
   If you need this feature, I'm afraid you'll have to do the entire data transformation on the front end instead of passing it to the back end.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2564: upstream discovery allow server name pass from request host

[GitBox <gi...@apache.org>]

bzp2010 commented on code in PR #2564:
URL: https://github.com/apache/apisix-dashboard/pull/2564#discussion_r936206628


##########
api/conf/schema.json:
##########
@@ -574,7 +574,7 @@
 						{
 							"required": [
 								"discovery_type",
-								"service_name",
+								"service_name_type",

Review Comment:
   Please do not modify this file, it is generated directly by the APISIX Control API and should not be edited by a human.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org