You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@apache.org> on 2008/07/02 23:50:45 UTC
[jira] Created: (SHINDIG-423) hardcoded fields in shindig
container.js
hardcoded fields in shindig container.js
----------------------------------------
Key: SHINDIG-423
URL: https://issues.apache.org/jira/browse/SHINDIG-423
Project: Shindig
Issue Type: Bug
Components: Features (Javascript)
Reporter: Henning Schmiedehausen
opensocial-reference/container.js contains
opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
if (opt_params && opt_params['escapeType'] == 'none') {
[...]
that should probably be
opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
if (opt_params && opt_params[opensocial.DataRequest.DataRequestFields.ESCAPE_TYPE] == opensocial.EscapeType.NONE) {
[...]
right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-423) hardcoded fields in shindig
container.js
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628813#action_12628813 ]
Cassie Doll commented on SHINDIG-423:
-------------------------------------
just fyi - on the spec list it was decided that all of the enum values should become part of the official spec docs (they were left out before just because of default js doc rendering)
so now, using string values instead of constants is fine and spec supported.
> hardcoded fields in shindig container.js
> ----------------------------------------
>
> Key: SHINDIG-423
> URL: https://issues.apache.org/jira/browse/SHINDIG-423
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Henning Schmiedehausen
> Attachments: fix-423-bug.patch
>
>
> opensocial-reference/container.js contains
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params['escapeType'] == 'none') {
> [...]
> that should probably be
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params[opensocial.DataRequest.DataRequestFields.ESCAPE_TYPE] == opensocial.EscapeType.NONE) {
> [...]
> right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-423) hardcoded fields in shindig
container.js
Posted by "Reema Sardana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reema Sardana updated SHINDIG-423:
----------------------------------
Attachment: fix-423-bug.patch
I think the string constant should be replaced.
> hardcoded fields in shindig container.js
> ----------------------------------------
>
> Key: SHINDIG-423
> URL: https://issues.apache.org/jira/browse/SHINDIG-423
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Henning Schmiedehausen
> Attachments: fix-423-bug.patch
>
>
> opensocial-reference/container.js contains
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params['escapeType'] == 'none') {
> [...]
> that should probably be
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params[opensocial.DataRequest.DataRequestFields.ESCAPE_TYPE] == opensocial.EscapeType.NONE) {
> [...]
> right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-423) hardcoded fields in shindig
container.js
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611415#action_12611415 ]
Cassie Doll commented on SHINDIG-423:
-------------------------------------
well javascript doesn't have real compiling anyway... so this is just sort of a pick your poison type of thing. either the code is long and less readable... or you use the string constant versions.
anybody have strong feelings?
> hardcoded fields in shindig container.js
> ----------------------------------------
>
> Key: SHINDIG-423
> URL: https://issues.apache.org/jira/browse/SHINDIG-423
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Henning Schmiedehausen
>
> opensocial-reference/container.js contains
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params['escapeType'] == 'none') {
> [...]
> that should probably be
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params[opensocial.DataRequest.DataRequestFields.ESCAPE_TYPE] == opensocial.EscapeType.NONE) {
> [...]
> right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-423) hardcoded fields in shindig
container.js
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-423.
----------------------------------
Resolution: Fixed
Fix Version/s: trunk
in trunk..
> hardcoded fields in shindig container.js
> ----------------------------------------
>
> Key: SHINDIG-423
> URL: https://issues.apache.org/jira/browse/SHINDIG-423
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Henning Schmiedehausen
> Fix For: trunk
>
> Attachments: fix-423-bug.patch
>
>
> opensocial-reference/container.js contains
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params['escapeType'] == 'none') {
> [...]
> that should probably be
> opensocial.Container.escape = function(value, opt_params, opt_escapeObjects) {
> if (opt_params && opt_params[opensocial.DataRequest.DataRequestFields.ESCAPE_TYPE] == opensocial.EscapeType.NONE) {
> [...]
> right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.