[GitHub] [tvm] tkonolige commented on pull request #11846: Fix `std::locale("")` in profiling.cc

[GitBox <gi...@apache.org>]

tkonolige commented on PR #11846:
URL: https://github.com/apache/tvm/pull/11846#issuecomment-1164670406

   This PR broke the comma printing :(. `std::locale("")` is supposed to set the locale to the users preference. Quoting `man 3 setlocale`:
   
   > If  locale  is  an  empty string, "", each part of the locale that should be modified is set according to the environment variables.  The details are implementation-dependent.  For glibc, first (regardless of category), the environment variable LC_ALL is inspected, next the environment variable with the same name as the category (see the table above), and finally the environment
          variable LANG.  The first existing environment variable is used.  If its value is not a valid locale specification, the locale is unchanged, and setlocale() returns NULL.
   
   @yogurfrul The error you are getting seems like it may be caused by a misconfiguration of your system. Is `zh_CN.UTF-8` in your `/etc/locale.gen`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org