You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by gg...@apache.org on 2006/12/31 02:08:35 UTC
svn commit: r491359 -
/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
Author: ggregory
Date: Sat Dec 30 17:08:34 2006
New Revision: 491359
URL: http://svn.apache.org/viewvc?view=rev&rev=491359
Log:
Remove unnecessary cast from long to long.
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
Modified: jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java?view=diff&rev=491359&r1=491358&r2=491359
==============================================================================
--- jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java (original)
+++ jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java Sat Dec 30 17:08:34 2006
@@ -224,7 +224,7 @@
( ( data[ offset + 5 ] & 0xff ) << 8 ) +
( ( data[ offset + 6 ] & 0xff ) << 16 ) +
( ( data[ offset + 7 ] & 0xff ) << 24 );
- return ((long) high << 32) + (0xffffffffL & low);
+ return (high << 32) + (0xffffffffL & low);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r491359 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
Posted by Henri Yandell <fl...@gmail.com>.
https://issues.apache.org/jira/browse/IO-101 with a testSymmetryOfLong
in EndianUtilsTest.
With Gary's change, the fix becomes:
- return low + (high << 32);
+ return (high << 32) + (0xffffffffL & low);
The test still passes, so I guess things are good.
Hen
On 12/31/06, Stephen Colebourne <sc...@btopenworld.com> wrote:
> This was a recent bug fix. Do we have tests to show that removing this
> cast doesn't cause the bug to reappear?
>
> Stephen
>
>
> ggregory@apache.org wrote:
> > Author: ggregory
> > Date: Sat Dec 30 17:08:34 2006
> > New Revision: 491359
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=491359
> > Log:
> > Remove unnecessary cast from long to long.
> >
> > Modified:
> > jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
> >
> > Modified: jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
> > URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java?view=diff&rev=491359&r1=491358&r2=491359
> > ==============================================================================
> > --- jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java (original)
> > +++ jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java Sat Dec 30 17:08:34 2006
> > @@ -224,7 +224,7 @@
> > ( ( data[ offset + 5 ] & 0xff ) << 8 ) +
> > ( ( data[ offset + 6 ] & 0xff ) << 16 ) +
> > ( ( data[ offset + 7 ] & 0xff ) << 24 );
> > - return ((long) high << 32) + (0xffffffffL & low);
> > + return (high << 32) + (0xffffffffL & low);
> > }
> >
> > /**
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r491359 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
Posted by Stephen Colebourne <sc...@btopenworld.com>.
This was a recent bug fix. Do we have tests to show that removing this
cast doesn't cause the bug to reappear?
Stephen
ggregory@apache.org wrote:
> Author: ggregory
> Date: Sat Dec 30 17:08:34 2006
> New Revision: 491359
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=491359
> Log:
> Remove unnecessary cast from long to long.
>
> Modified:
> jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
>
> Modified: jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java
> URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java?view=diff&rev=491359&r1=491358&r2=491359
> ==============================================================================
> --- jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java (original)
> +++ jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java Sat Dec 30 17:08:34 2006
> @@ -224,7 +224,7 @@
> ( ( data[ offset + 5 ] & 0xff ) << 8 ) +
> ( ( data[ offset + 6 ] & 0xff ) << 16 ) +
> ( ( data[ offset + 7 ] & 0xff ) << 24 );
> - return ((long) high << 32) + (0xffffffffL & low);
> + return (high << 32) + (0xffffffffL & low);
> }
>
> /**
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org