You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/13 20:24:18 UTC

[GitHub] [airflow] HaloKo4 commented on a change in pull request #10437: Fixes MySQLToS3 float to int conversion

HaloKo4 commented on a change in pull request #10437:
URL: https://github.com/apache/airflow/pull/10437#discussion_r504236662



##########
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##########
@@ -105,7 +105,8 @@ def _fix_int_dtypes(self, df):
                 notna_series = df[col].dropna().values
                 if np.isclose(notna_series, notna_series.astype(int)).all():
                     # set to dtype that retains integers and supports NaNs
-                    df[col] = np.where(df[col].isnull(), None, df[col]).astype(pd.Int64Dtype)
+                    df[col] = np.where(df[col].isnull(), None, df[col])
+                    df[col] = df[col].astype(pd.Int64Dtype())

Review comment:
       @gmontanola are you planning to finish it? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org