You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/06 00:05:24 UTC
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2911: [Gobblin-1069]Add NPE check in handleContainerCompletion method
sv2000 commented on a change in pull request #2911: [Gobblin-1069]Add NPE check in handleContainerCompletion method
URL: https://github.com/apache/incubator-gobblin/pull/2911#discussion_r388636060
##########
File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java
##########
@@ -621,7 +621,8 @@ private boolean shouldStickToTheSameNode(int containerExitStatus) {
protected void handleContainerCompletion(ContainerStatus containerStatus) {
Map.Entry<Container, String> completedContainerEntry = this.containerMap.remove(containerStatus.getContainerId());
if (completedContainerEntry == null) {
Review comment:
Rather than if (completedContainerEntry == null) here, how about surrounding lines 647-676 inside if(completedContainerEntry != null) {...}? Ideally, we would still like to print out the container diagnostic log lines, and check if the container is in the releasedContainerCache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services