You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2016/12/16 06:16:20 UTC

Review Request 54806: ATLAS-1395 : Lineage improvement for tooltip

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54806/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Mehul Parikh, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1395
    https://issues.apache.org/jira/browse/ATLAS-1395


Repository: atlas


Description
-------

This patch containes Lineage tooltip improvement.

Format:

`````````````````````````` 
--------------------------
|        <name>          |
|      <type_name>       |
|                        |
--------------------------
``````````````````````````

Both name and typename will be center align inside tooltip


Diffs
-----

  dashboardv2/public/js/views/graph/LineageLayoutView.js d16674e 

Diff: https://reviews.apache.org/r/54806/diff/


Testing
-------

Tested with quickstart data


Thanks,

keval bhatt


Re: Review Request 54806: ATLAS-1395 : Lineage improvement for tooltip

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54806/#review159443
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 16, 2016, 11:31 a.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54806/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 11:31 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Mehul Parikh, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1395
>     https://issues.apache.org/jira/browse/ATLAS-1395
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch containes Lineage tooltip improvement.
> 
> Format:
> 
> `````````````````````````` 
> 
> --------------------------
> |        <name>          |
> |      <type_name>       |
> |                        |
> --------------------------
> 
> 
> ``````````````````````````
> 
> Both name and typename will be center align inside tooltip
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js d16674e 
> 
> Diff: https://reviews.apache.org/r/54806/diff/
> 
> 
> Testing
> -------
> 
> Tested with quickstart data
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Re: Review Request 54806: ATLAS-1395 : Lineage improvement for tooltip

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54806/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 11:31 a.m.)


Review request for atlas, Madhan Neethiraj, Mehul Parikh, Suma Shivaprasad, and Vimal Sharma.


Changes
-------

Tooltip will be shown on hover of label also


Bugs: ATLAS-1395
    https://issues.apache.org/jira/browse/ATLAS-1395


Repository: atlas


Description
-------

This patch containes Lineage tooltip improvement.

Format:

`````````````````````````` 

--------------------------
|        <name>          |
|      <type_name>       |
|                        |
--------------------------


``````````````````````````

Both name and typename will be center align inside tooltip


Diffs (updated)
-----

  dashboardv2/public/js/views/graph/LineageLayoutView.js d16674e 

Diff: https://reviews.apache.org/r/54806/diff/


Testing
-------

Tested with quickstart data


Thanks,

keval bhatt


Re: Review Request 54806: ATLAS-1395 : Lineage improvement for tooltip

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54806/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 6:17 a.m.)


Review request for atlas, Madhan Neethiraj, Mehul Parikh, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1395
    https://issues.apache.org/jira/browse/ATLAS-1395


Repository: atlas


Description (updated)
-------

This patch containes Lineage tooltip improvement.

Format:

`````````````````````````` 

--------------------------
|        <name>          |
|      <type_name>       |
|                        |
--------------------------


``````````````````````````

Both name and typename will be center align inside tooltip


Diffs
-----

  dashboardv2/public/js/views/graph/LineageLayoutView.js d16674e 

Diff: https://reviews.apache.org/r/54806/diff/


Testing
-------

Tested with quickstart data


Thanks,

keval bhatt


Re: Review Request 54806: ATLAS-1395 : Lineage improvement for tooltip

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54806/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 6:17 a.m.)


Review request for atlas, Madhan Neethiraj, Mehul Parikh, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1395
    https://issues.apache.org/jira/browse/ATLAS-1395


Repository: atlas


Description (updated)
-------

This patch containes Lineage tooltip improvement.

Format:

`````````````````````````` 
--------------------------
|        <name>          |
|      <type_name>       |
|                        |
--------------------------

``````````````````````````

Both name and typename will be center align inside tooltip


Diffs
-----

  dashboardv2/public/js/views/graph/LineageLayoutView.js d16674e 

Diff: https://reviews.apache.org/r/54806/diff/


Testing
-------

Tested with quickstart data


Thanks,

keval bhatt