You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/26 01:40:38 UTC

[GitHub] [camel-k] claudio4j commented on a diff in pull request #3838: Fix tests related to recent camel-k-runtime changes

claudio4j commented on code in PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#discussion_r1032722760


##########
pkg/util/dsl/template.go:
##########
@@ -41,7 +41,7 @@ func TemplateToYamlDSL(template v1.Template, id string) ([]byte, error) {
 		jsondata["id"] = id
 	}
 	templateWrapper := make(map[string]interface{}, 2)
-	templateWrapper["template"] = jsondata

Review Comment:
   I removed the array, but that bring a conversion error in camel yaml dsl. To proceed with having `main` in a good state, can we merge as it is, and we can review this array later  ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org