[GitHub] [arrow-datafusion] alamb commented on pull request #6364: Cleanup ExternalSorter metrics (#5885)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #6364:
URL: https://github.com/apache/arrow-datafusion/pull/6364#issuecomment-1551205097

   My benchmark run shows no changes in performance, as expected
   
   ```
   --------------------
   Benchmark sort.json
   --------------------
   ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
   ┃ Query        ┃       sort ┃       sort ┃        Change ┃
   ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
   │ Qsort utf8   │ 63572.72ms │ 65037.97ms │     no change │
   │ Qsort int    │ 77433.88ms │ 75017.20ms │     no change │
   │ Qsort        │ 65095.90ms │ 63913.09ms │     no change │
   │ decimal      │            │            │               │
   │ Qsort        │ 83230.11ms │ 80413.45ms │     no change │
   │ integer      │            │            │               │
   │ tuple        │            │            │               │
   │ Qsort utf8   │ 64949.20ms │ 61437.19ms │ +1.06x faster │
   │ tuple        │            │            │               │
   │ Qsort mixed  │ 74037.84ms │ 70042.36ms │ +1.06x faster │
   │ tuple        │            │            │               │
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org