You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2016/01/13 21:22:46 UTC
[GitHub] curator pull request: [CURATOR-208] General fix for catch-alls thr...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/125
[CURATOR-208] General fix for catch-alls throughout the code and interruptes
General fix for catch-alls throughout the code. This is overkill but it strikes me as the safest way to address the problem. Everywhere there is a catch-all add a check for InterruptedException and reset the thread's interrupted state
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 003acc6027aa63e59b5de3b0d1da7e33c2b9f9cc
Author: randgalt <ra...@apache.org>
Date: 2016-01-13T20:20:54Z
General fix for catch-alls throughout the code. This is overkill but it strikes me as the safest way to address the problem. Everywhere there is a catch-all add a check for InterruptedException and reset the thread's interrupted state
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-208] General fix for catch-alls thr...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/125#issuecomment-172389430
Looks ok to me I think. I agree that it's kind of brute force, but I can't think of a cleaner way of doing it without a complete audit of the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-208] General fix for catch-alls thr...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on a diff in the pull request:
https://github.com/apache/curator/pull/125#discussion_r49953173
--- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
@@ -257,8 +258,7 @@ public void stateChanged(CuratorFramework client, ConnectionState newState)
client.start();
- executorService = Executors.newFixedThreadPool(2, threadFactory); // 1 for listeners, 1 for background ops
-
+ executorService = Executors.newSingleThreadScheduledExecutor(threadFactory);
--- End diff --
Is there a reason that this has gone from a 2 thread pool to a single thread pool? Looking at the old code, it would seem that only 1 is used (for the background loop), but just double checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-208] General fix for catch-alls thr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-208] General fix for catch-alls thr...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/125#discussion_r49953348
--- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
@@ -257,8 +258,7 @@ public void stateChanged(CuratorFramework client, ConnectionState newState)
client.start();
- executorService = Executors.newFixedThreadPool(2, threadFactory); // 1 for listeners, 1 for background ops
-
+ executorService = Executors.newSingleThreadScheduledExecutor(threadFactory);
--- End diff --
The comment was wrong. This must have changed at some point. I noticed only 1 was being used and corrected it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---