You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by gm...@apache.org on 2009/01/12 02:03:06 UTC
svn commit: r733561 - in
/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt:
css/pelt.screen.css panels/pelt-html.nav-main.panel.xml
Author: gmcdonald
Date: Sun Jan 11 17:03:05 2009
New Revision: 733561
URL: http://svn.apache.org/viewvc?rev=733561&view=rev
Log:
Move 2nd level tabs to correct location
Modified:
forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css
forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml
Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css
URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css?rev=733561&r1=733560&r2=733561&view=diff
==============================================================================
--- forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css (original)
+++ forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css Sun Jan 11 17:03:05 2009
@@ -210,6 +210,7 @@
padding-left: 10px;
margin: 0;
list-style: none;
+ padding-top:18px;
}
#nav-main li {
@@ -285,6 +286,7 @@
float:left;
position:relative;
background-color: #4A6D8C ;
+ z-index:30;
}
#level2tabs a {padding-right: 5px;
background-color: #CFDCED;
Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml?rev=733561&r1=733560&r2=733561&view=diff
==============================================================================
--- forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml (original)
+++ forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml Sun Jan 11 17:03:05 2009
@@ -28,9 +28,9 @@
<forrest:hook name="nav-main-hook">
<forrest:contract name="nav-main"
dataURI="cocoon://#{$getRequest}.navigation.xml"/>
+ <forrest:hook name="publishedStrip" nbsp="true">
<forrest:contract name="nav-main-sub"
dataURI="cocoon://#{$getRequest}.navigation.xml"/>
- <forrest:hook name="publishedStrip" nbsp="true">
<forrest:contract name="siteinfo-last-published"/>
</forrest:hook>
</forrest:hook>
RE: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by Gavin <ga...@16degrees.com.au>.
> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Tuesday, 13 January 2009 10:09 AM
> To: dev@forrest.apache.org
> Subject: Re: recent CSS changes side-effect (Was: svn commit: r733561)
>
> Gavin wrote:
> > From: David Crossley
> > >
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> > > t/css/pelt.screen.css Sun Jan 11 17:03:05 2009
> > > > @@ -210,6 +210,7 @@
> > > > padding-left: 10px;
> > > > margin: 0;
> > > > list-style: none;
> > > > + padding-top:18px;
> > > > }
> > >
> > > Why introduce this big gap at the top of the left-hand menu
> > > for all pages?
> >
> > Hmm, any chance of a screenshot?
>
> It can be seen at http://forrest.zones.apache.org/ft/build/forrest-sample-
> 2/
> i.e. the Dispatcher-based site.
Yes I've been testing and comparing using that site all along. Considering
that I'm trying to accomplish cross-browser and cross-platform fix for the
initial problems, what you see and what I see could have been very different
things, hence my request for a screenshot from you.
However, that said, I now get your talking about and can see the same.
I will work out another way to reveal the 2nd level tabs. For now I'll that
part back, this will hide them from IE7 users (possibly IE6 too but I don't
have that any more).
Using conditional statements and sending IE users to another stylesheet
would be the appropriate solution. All these tantek and others hacks do not
work in IE7 or above, separate stylesheets are the way to go for
cross-browser solutions. That however goes against your current thinking of
reducing stylesheets.
Gav...
> On all pages, the left-hand menu is now 18 pixels lower.
> See the now bigger blue section (gap) at the top.
>
> The amount of room available in the side menu is limited.
> We cannot afford to move it even further down the page.
>
> -David
>
> > I'm not seeing a big gap anywhere, tested in Firefox 2 (win and linux),
> > Firefox 3 (win and linux), IE7 (win), Opera (win) and Safari (win)
> >
> > The change was introduced, because locally during a forrest run and
> forrest
> > site , and confirmed on forrest.zones - the 2nd level tabs once
> positioned
> > correctly in the last-published area, were hidden from view behind the
> > leftnav, this was in IE only, in others I cured it by use of z-index to
> > bring the 2nd level tabs to the top, IE was not affected by this change.
> >
> > So by bringing the leftnav down by 18px it revealed the hidden 2nd level
> > tabs on IE, whilst still being attached to the top nav area, so no gaps.
> >
> > At least that's how it tests on my 3 monitors of varied resolutions, 2
> > operating systems, and 5 web browsers. Not having a genuine MAC I can't
> test
> > on that.
> >
> > Level 2 tabs have been broken for quite some time, appearing out of
> place on
> > the same row as the main tabs, to me now, they are correctly positioned
> from
> > the work of the last day or two (not just by the padding-top addition
> you
> > point out above.)
> >
> > In case you can't get a screenshot to me, I'll submit the forrest.zones
> to
> > browsershots and see what that comes up with.
> >
> > Gav...
>
>
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.552 / Virus Database: 270.10.6/1888 - Release Date: 1/12/2009
> 7:04 AM
Re: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by David Crossley <cr...@apache.org>.
Gavin wrote:
> From: David Crossley
> > forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> > t/css/pelt.screen.css Sun Jan 11 17:03:05 2009
> > > @@ -210,6 +210,7 @@
> > > padding-left: 10px;
> > > margin: 0;
> > > list-style: none;
> > > + padding-top:18px;
> > > }
> >
> > Why introduce this big gap at the top of the left-hand menu
> > for all pages?
>
> Hmm, any chance of a screenshot?
It can be seen at http://forrest.zones.apache.org/ft/build/forrest-sample-2/
i.e. the Dispatcher-based site.
On all pages, the left-hand menu is now 18 pixels lower.
See the now bigger blue section (gap) at the top.
The amount of room available in the side menu is limited.
We cannot afford to move it even further down the page.
-David
> I'm not seeing a big gap anywhere, tested in Firefox 2 (win and linux),
> Firefox 3 (win and linux), IE7 (win), Opera (win) and Safari (win)
>
> The change was introduced, because locally during a forrest run and forrest
> site , and confirmed on forrest.zones - the 2nd level tabs once positioned
> correctly in the last-published area, were hidden from view behind the
> leftnav, this was in IE only, in others I cured it by use of z-index to
> bring the 2nd level tabs to the top, IE was not affected by this change.
>
> So by bringing the leftnav down by 18px it revealed the hidden 2nd level
> tabs on IE, whilst still being attached to the top nav area, so no gaps.
>
> At least that's how it tests on my 3 monitors of varied resolutions, 2
> operating systems, and 5 web browsers. Not having a genuine MAC I can't test
> on that.
>
> Level 2 tabs have been broken for quite some time, appearing out of place on
> the same row as the main tabs, to me now, they are correctly positioned from
> the work of the last day or two (not just by the padding-top addition you
> point out above.)
>
> In case you can't get a screenshot to me, I'll submit the forrest.zones to
> browsershots and see what that comes up with.
>
> Gav...
RE: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by Gavin <ga...@16degrees.com.au>.
Ok,
some browser shots are appearing on
http://browsershots.org/http://forrest.zones.apache.org/ft/build/forrest-sam
ple-2/samples-a/index.html
Unfortunately its looking like no MAC shots available.
Whats uploaded so far does not produce a gap, we'll wait and see what others
come out at. The search button is still broken outside of its box, not on my
systems however, so need to look at that more too.
Gav...
> -----Original Message-----
> From: Gavin [mailto:gavin@16degrees.com.au]
> Sent: Tuesday, 13 January 2009 9:00 AM
> To: dev@forrest.apache.org
> Subject: RE: recent CSS changes side-effect (Was: svn commit: r733561)
>
>
>
> > -----Original Message-----
> > From: Gavin [mailto:gavin@16degrees.com.au]
> > Sent: Tuesday, 13 January 2009 8:41 AM
> > To: dev@forrest.apache.org
> > Subject: RE: recent CSS changes side-effect (Was: svn commit: r733561)
> >
> >
> >
> > In case you can't get a screenshot to me, I'll submit the forrest.zones
> to
> > browsershots and see what that comes up with.
>
> hmm, no I wont, forrest zone is blocking browsershots.org as a user agent.
>
> Can someone with root on the zone follow the advice on
>
> http://trac.browsershots.org/wiki/FrequentlyAskedQuestions#Blockedbyrobots
> .t
> xt
>
> it would be handy to have it available.
>
> >
> > Gav...
> >
> > >
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.552 / Virus Database: 270.10.6/1888 - Release Date: 1/12/2009
> 7:04 AM
Re: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by David Crossley <cr...@apache.org>.
Gavin wrote:
> > >
> > > In case you can't get a screenshot to me, I'll submit the forrest.zones
> > to
> > > browsershots and see what that comes up with.
> >
> > hmm, no I wont, forrest zone is blocking browsershots.org as a user agent.
> >
> > Can someone with root on the zone follow the advice on
> >
> > http://trac.browsershots.org/wiki/FrequentlyAskedQuestions#Blockedbyrobots
> > .t
> > xt
> >
> > it would be handy to have it available.
>
> never mind, root wasn't needed for that file, its done.
Please make such changes in SVN, then do 'svn up' on the server.
http://forrest.apache.org/zone.html
https://svn.apache.org/repos/asf/forrest/zone/htdocs/robots.txt
-David
RE: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by Gavin <ga...@16degrees.com.au>.
> -----Original Message-----
> From: Gavin [mailto:gavin@16degrees.com.au]
> Sent: Tuesday, 13 January 2009 9:00 AM
> To: dev@forrest.apache.org
> Subject: RE: recent CSS changes side-effect (Was: svn commit: r733561)
>
>
>
> > -----Original Message-----
> > From: Gavin [mailto:gavin@16degrees.com.au]
> > Sent: Tuesday, 13 January 2009 8:41 AM
> > To: dev@forrest.apache.org
> > Subject: RE: recent CSS changes side-effect (Was: svn commit: r733561)
> >
> >
> >
> > In case you can't get a screenshot to me, I'll submit the forrest.zones
> to
> > browsershots and see what that comes up with.
>
> hmm, no I wont, forrest zone is blocking browsershots.org as a user agent.
>
> Can someone with root on the zone follow the advice on
>
> http://trac.browsershots.org/wiki/FrequentlyAskedQuestions#Blockedbyrobots
> .t
> xt
>
> it would be handy to have it available.
never mind, root wasn't needed for that file, its done.
>
> >
> > Gav...
> >
> > >
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.552 / Virus Database: 270.10.6/1888 - Release Date: 1/12/2009
> 7:04 AM
RE: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by Gavin <ga...@16degrees.com.au>.
> -----Original Message-----
> From: Gavin [mailto:gavin@16degrees.com.au]
> Sent: Tuesday, 13 January 2009 8:41 AM
> To: dev@forrest.apache.org
> Subject: RE: recent CSS changes side-effect (Was: svn commit: r733561)
>
>
>
> In case you can't get a screenshot to me, I'll submit the forrest.zones to
> browsershots and see what that comes up with.
hmm, no I wont, forrest zone is blocking browsershots.org as a user agent.
Can someone with root on the zone follow the advice on
http://trac.browsershots.org/wiki/FrequentlyAskedQuestions#Blockedbyrobots.t
xt
it would be handy to have it available.
>
> Gav...
>
> >
RE: recent CSS changes side-effect (Was: svn commit: r733561)
Posted by Gavin <ga...@16degrees.com.au>.
> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Tuesday, 13 January 2009 7:56 AM
> To: Forrest Developers List
> Subject: recent CSS changes side-effect (Was: svn commit: r733561)
>
> > Author: gmcdonald
> > Date: Sun Jan 11 17:03:05 2009
> > New Revision: 733561
> >
> > URL: http://svn.apache.org/viewvc?rev=733561&view=rev
> > Log:
> > Move 2nd level tabs to correct location
> >
> > Modified:
> >
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css
> >
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml
> >
> > Modified:
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css
> > URL:
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.themes.core/themes/pelt/css/pelt.screen.css?rev=733561&r1=733560&r2
> =733561&view=diff
> >
> ==========================================================================
> ====
> > ---
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css (original)
> > +++
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css Sun Jan 11 17:03:05 2009
> > @@ -210,6 +210,7 @@
> > padding-left: 10px;
> > margin: 0;
> > list-style: none;
> > + padding-top:18px;
> > }
>
> Why introduce this big gap at the top of the left-hand menu
> for all pages?
Hmm, any chance of a screenshot?
I'm not seeing a big gap anywhere, tested in Firefox 2 (win and linux),
Firefox 3 (win and linux), IE7 (win), Opera (win) and Safari (win)
The change was introduced, because locally during a forrest run and forrest
site , and confirmed on forrest.zones - the 2nd level tabs once positioned
correctly in the last-published area, were hidden from view behind the
leftnav, this was in IE only, in others I cured it by use of z-index to
bring the 2nd level tabs to the top, IE was not affected by this change.
So by bringing the leftnav down by 18px it revealed the hidden 2nd level
tabs on IE, whilst still being attached to the top nav area, so no gaps.
At least that's how it tests on my 3 monitors of varied resolutions, 2
operating systems, and 5 web browsers. Not having a genuine MAC I can't test
on that.
Level 2 tabs have been broken for quite some time, appearing out of place on
the same row as the main tabs, to me now, they are correctly positioned from
the work of the last day or two (not just by the padding-top addition you
point out above.)
In case you can't get a screenshot to me, I'll submit the forrest.zones to
browsershots and see what that comes up with.
Gav...
>
> -David
>
> > #nav-main li {
> > @@ -285,6 +286,7 @@
> > float:left;
> > position:relative;
> > background-color: #4A6D8C ;
> > + z-index:30;
> > }
> > #level2tabs a {padding-right: 5px;
> > background-color: #CFDCED;
> >
> > Modified:
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml
> > URL:
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.themes.core/themes/pelt/panels/pelt-html.nav-
> main.panel.xml?rev=733561&r1=733560&r2=733561&view=diff
> >
> ==========================================================================
> ====
> > ---
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml (original)
> > +++
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml Sun Jan 11 17:03:05 2009
> > @@ -28,9 +28,9 @@
> > <forrest:hook name="nav-main-hook">
> > <forrest:contract name="nav-main"
> > dataURI="cocoon://#{$getRequest}.navigation.xml"/>
> > + <forrest:hook name="publishedStrip" nbsp="true">
> > <forrest:contract name="nav-main-sub"
> > dataURI="cocoon://#{$getRequest}.navigation.xml"/>
> > - <forrest:hook name="publishedStrip" nbsp="true">
> > <forrest:contract name="siteinfo-last-published"/>
> > </forrest:hook>
> > </forrest:hook>
> >
> >
> >
>
>
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.552 / Virus Database: 270.10.6/1888 - Release Date: 1/12/2009
> 7:04 AM
recent CSS changes side-effect (Was: svn commit: r733561)
Posted by David Crossley <cr...@apache.org>.
> Author: gmcdonald
> Date: Sun Jan 11 17:03:05 2009
> New Revision: 733561
>
> URL: http://svn.apache.org/viewvc?rev=733561&view=rev
> Log:
> Move 2nd level tabs to correct location
>
> Modified:
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml
>
> Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css
> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css?rev=733561&r1=733560&r2=733561&view=diff
> ==============================================================================
> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css (original)
> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css Sun Jan 11 17:03:05 2009
> @@ -210,6 +210,7 @@
> padding-left: 10px;
> margin: 0;
> list-style: none;
> + padding-top:18px;
> }
Why introduce this big gap at the top of the left-hand menu
for all pages?
-David
> #nav-main li {
> @@ -285,6 +286,7 @@
> float:left;
> position:relative;
> background-color: #4A6D8C ;
> + z-index:30;
> }
> #level2tabs a {padding-right: 5px;
> background-color: #CFDCED;
>
> Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml
> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml?rev=733561&r1=733560&r2=733561&view=diff
> ==============================================================================
> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml (original)
> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/panels/pelt-html.nav-main.panel.xml Sun Jan 11 17:03:05 2009
> @@ -28,9 +28,9 @@
> <forrest:hook name="nav-main-hook">
> <forrest:contract name="nav-main"
> dataURI="cocoon://#{$getRequest}.navigation.xml"/>
> + <forrest:hook name="publishedStrip" nbsp="true">
> <forrest:contract name="nav-main-sub"
> dataURI="cocoon://#{$getRequest}.navigation.xml"/>
> - <forrest:hook name="publishedStrip" nbsp="true">
> <forrest:contract name="siteinfo-last-published"/>
> </forrest:hook>
> </forrest:hook>
>
>
>