You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/08/22 23:19:49 UTC
[GitHub] [geode] kirklund opened pull request #2367: GEODE-5614:
rename DistributedTestRule as DistributedRule
* Cleanup javadocs on rules that referred to DistributedTestRule.
* Add ClientCacheFactoryDistributedTest for ClientCacheRule.
[ Full content available at: https://github.com/apache/geode/pull/2367 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [geode] kirklund commented on issue #2367: GEODE-5614:
rename DistributedTestRule as DistributedRule
Posted by "kirklund (GitHub)" <gi...@apache.org>.
Please review @dhemery @balesh2
[ Full content available at: https://github.com/apache/geode/pull/2367 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2367:
GEODE-5614: rename DistributedTestRule as DistributedRule
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
do you want to rename these static fields names to "distributedRule"? It is in a large number of files
[ Full content available at: https://github.com/apache/geode/pull/2367 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [geode] kirklund closed pull request #2367: GEODE-5614:
rename DistributedTestRule as DistributedRule
Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2367 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #2367:
GEODE-5614: rename DistributedTestRule as DistributedRule
Posted by "kirklund (GitHub)" <gi...@apache.org>.
I wasn't planning to but every class containing the old variable name was touched anyway, so I probably should go ahead and do it. Thanks!
[ Full content available at: https://github.com/apache/geode/pull/2367 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org