You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/30 12:30:56 UTC
[GitHub] [iotdb] jamber001 opened a new pull request #2949: [IOTDB-1265] fix bug: correct cluster to iotdb-cluster
jamber001 opened a new pull request #2949:
URL: https://github.com/apache/iotdb/pull/2949
## Description
JIRA: IOTDB-1265, cluster package refactor missed necessary change
There was ever below change：
=============================================================
commit 64c11bc259cfc948286b8bf299792380766deb25
Author: wangchao316 <66...@users.noreply.github.com>
Date: Tue Mar 23 20:54:44 2021 +0800
IOTDB-1255 refactor cluster package and jar name (#2892)
diff --git a/cluster/pom.xml b/cluster/pom.xml
index 1d2969321..9a15a0daa 100644
— a/cluster/pom.xml
+++ b/cluster/pom.xml
@@ -27,7 +27,7 @@
<version>0.12.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>cluster</artifactId>
+ <artifactId>iotdb-cluster</artifactId>
<name>cluster</name>
<properties>
<cluster.test.skip>false</cluster.test.skip>
============================================================
but above commit missed below 2 points' change
=============================================================
vi distribution/pom.xml
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>cluster</artifactId> //should be <artifactId>iotdb-cluster</artifactId>
<version>${project.version}</version>
<type>zip</type>
</dependency>
vi distribution/src/assembly/cluster.xml
<dependencySets>
<dependencySet>
<includes>
<include>:cluster:zip:</include> //should be <include>:iotdb-cluster:zip:</include>
<include>:iotdb-cli:zip:</include>
</includes>
=============================================================
When you run cmd "mvn clean pacakge",
above bug will cause final package(apache-iotdb-xxx-cluster-bin.zip) contains old files that are from cluster-xxx.zip（from Maven repo).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sunjincheng121 commented on pull request #2949: [IOTDB-1265] fix bug: correct cluster to iotdb-cluster
Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on pull request #2949:
URL: https://github.com/apache/iotdb/pull/2949#issuecomment-810675434
Thanks for the PR @jamber001 !
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan merged pull request #2949: [IOTDB-1265] fix bug: correct cluster to iotdb-cluster
Posted by GitBox <gi...@apache.org>.
neuyilan merged pull request #2949:
URL: https://github.com/apache/iotdb/pull/2949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sunjincheng121 commented on pull request #2949: [IOTDB-1265] fix bug: correct cluster to iotdb-cluster
Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on pull request #2949:
URL: https://github.com/apache/iotdb/pull/2949#issuecomment-810739369
Close the JIRA with the commit :92e4755ec32d524897c02508c113a1ab84b1a969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org