You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/08/12 13:24:11 UTC
[GitHub] [rocketmq-externals] yiliuchen commented on a change in pull request #381: 【ISSUE #278】Define and Implement the RmqConnector and RmqSourceTask.
yiliuchen commented on a change in pull request #381: 【ISSUE #278】Define and Implement the RmqConnector and RmqSourceTask.
URL: https://github.com/apache/rocketmq-externals/pull/381#discussion_r312921338
##########
File path: rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/RmqSourceReplicator.java
##########
@@ -146,33 +122,51 @@ public void resume() {
public List<KeyValue> taskConfigs() {
- if (started && configValid) {
+ if (configValid) {
+
+ boolean adminStarted = false;
+ RPCHook rpcHook = null;
+ DefaultMQAdminExt defaultMQAdminExt = new DefaultMQAdminExt(rpcHook);
+ defaultMQAdminExt.setNamesrvAddr(this.replicatorConfig.getString(ConfigDefine.CONN_SOURCE_RMQ));
+ defaultMQAdminExt.setInstanceName(Utils.createGroupName(ConstDefine.REPLICATOR_ADMIN_PREFIX));
Review comment:
It was changed back here。
this.defaultMQAdminExt.setAdminExtGroup(Utils.createGroupName(ConstDefine.REPLICATOR_ADMIN_PREFIX));
this.defaultMQAdminExt.setInstanceName(Utils.createInstanceName(this.config.getString(ConfigDefine.CONN_SOURCE_RMQ)));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services