[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1314: MINIFICPP-1808 Improve RawSocketProtocol authorization error logging

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1314:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1314#discussion_r856154796


##########
libminifi/src/sitetosite/RawSocketProtocol.cpp:
##########
@@ -240,6 +240,12 @@ bool RawSiteToSiteClient::initiateCodecResourceNegotiation() {
   }
 }
 
+namespace {
+void logPortStateError(std::shared_ptr<core::logging::Logger>& logger, utils::Identifier port_id, const std::string& error) {

Review Comment:
   Would this may be simpler as a lambda inside `RawSiteToSiteClient::handShake`? We could lose 2 parameters that way.
   
   ```
   auto logPortStateError = [this](const std::string& error) { logger_->log_error("Site2Site HandShake Failed because destination port, %s, is %s", port_id_.to_string(), error); };
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org