You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/27 07:16:42 UTC
[GitHub] [arrow] liyafan82 opened a new pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
liyafan82 opened a new pull request #7837:
URL: https://github.com/apache/arrow/pull/7837
See https://issues.apache.org/jira/browse/ARROW-9554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-664855122
> What do we think about adding tests that use randomly generated data?
Sounds reasonable. I have added test cases for random data. Please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r469408080
##########
File path: java/algorithm/src/main/java/org/apache/arrow/algorithm/sort/VariableWidthOutOfPlaceVectorSorter.java
##########
@@ -45,6 +46,22 @@ public void sortOutOfPlace(V srcVector, V dstVector, VectorValueComparator<V> co
ArrowBuf dstValueBuffer = dstVector.getDataBuffer();
ArrowBuf dstOffsetBuffer = dstVector.getOffsetBuffer();
+ // check buffer size
+ Preconditions.checkArgument(dstValidityBuffer.capacity() * 8 >= srcVector.getValueCount(),
+ "Not enough capacity for the validity buffer of the dst vector. " +
+ "Expected capacity %s, actual capacity %s",
+ (srcVector.getValueCount() + 7) / 8, dstValidityBuffer.capacity());
+ Preconditions.checkArgument(
+ dstOffsetBuffer.capacity() >= srcVector.getValueCount() * BaseVariableWidthVector.OFFSET_WIDTH,
+ "Not enough capacity for the offset buffer of the dst vector. " +
+ "Expected capacity %s, actual capacity %s",
+ srcVector.getValueCount() * BaseVariableWidthVector.OFFSET_WIDTH, dstValueBuffer.capacity());
Review comment:
nit: `dstValueBuffer` -> `dstOffsetBuffer`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-664166155
https://issues.apache.org/jira/browse/ARROW-9554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 closed pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 closed pull request #7837:
URL: https://github.com/apache/arrow/pull/7837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] chairmank commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
chairmank commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-665024212
This pull request looks good to me. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-674349555
@liyafan82 any reason why this can't be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r463913968
##########
File path: java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestSortingUtil.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.algorithm.sort;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.lang.reflect.Array;
+import java.util.Arrays;
+import java.util.Random;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+
+import org.apache.arrow.vector.BigIntVector;
+import org.apache.arrow.vector.Float4Vector;
+import org.apache.arrow.vector.Float8Vector;
+import org.apache.arrow.vector.IntVector;
+import org.apache.arrow.vector.SmallIntVector;
+import org.apache.arrow.vector.TinyIntVector;
+import org.apache.arrow.vector.ValueVector;
+import org.apache.arrow.vector.VarCharVector;
+import org.apache.arrow.vector.testing.ValueVectorDataPopulator;
+
+/**
+ * Utilities for sorting related utilities.
+ */
+public class TestSortingUtil {
Review comment:
(in the vector pacakage along with Vector Populator)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] chairmank commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
chairmank commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r461560501
##########
File path: java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestSortingUtil.java
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.algorithm.sort;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.lang.reflect.Array;
+import java.util.Arrays;
+import java.util.Random;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+
+import org.apache.arrow.vector.BigIntVector;
+import org.apache.arrow.vector.Float4Vector;
+import org.apache.arrow.vector.Float8Vector;
+import org.apache.arrow.vector.IntVector;
+import org.apache.arrow.vector.SmallIntVector;
+import org.apache.arrow.vector.TinyIntVector;
+import org.apache.arrow.vector.ValueVector;
+import org.apache.arrow.vector.VarCharVector;
+import org.apache.arrow.vector.testing.ValueVectorDataPopulator;
+
+/**
+ * Utilities for sorting related utilities.
+ */
+public class TestSortingUtil {
+
+ static final Random random = new Random(0);
+
+ static final DataGenerator<TinyIntVector, Byte> TINY_INT_GENERATOR = new DataGenerator<>(
+ () -> (byte) random.nextInt(),
+ (vector, array) -> ValueVectorDataPopulator.setVector(vector, array), Byte.class);
+
+ static final DataGenerator<SmallIntVector, Short> SMALL_INT_GENERATOR = new DataGenerator<>(
+ () -> (short) random.nextInt(),
+ (vector, array) -> ValueVectorDataPopulator.setVector(vector, array), Short.class);
+
+ static final DataGenerator<IntVector, Integer> INT_GENERATOR = new DataGenerator<>(
+ () -> random.nextInt(),
+ (vector, array) -> ValueVectorDataPopulator.setVector(vector, array), Integer.class);
+
+ static final DataGenerator<BigIntVector, Long> LONG_GENERATOR = new DataGenerator<>(
+ () -> random.nextLong(),
+ (vector, array) -> ValueVectorDataPopulator.setVector(vector, array), Long.class);
+
+ static final DataGenerator<Float4Vector, Float> FLOAT_GENERATOR = new DataGenerator<>(
+ () -> random.nextFloat(),
+ (vector, array) -> ValueVectorDataPopulator.setVector(vector, array), Float.class);
+
+ static final DataGenerator<Float8Vector, Double> DOUBLE_GENERATOR = new DataGenerator<>(
+ () -> random.nextDouble(),
+ (vector, array) -> ValueVectorDataPopulator.setVector(vector, array), Double.class);
+
+ static final DataGenerator<VarCharVector, String> STRING_GENERATOR = new DataGenerator<>(
+ () -> {
+ int strLength = random.nextInt(20) + 1;
+ byte[] str = new byte[strLength];
+ random.nextBytes(str);
+ return new String(str);
Review comment:
I think that this can generate strings that are not valid UTF-8. `VarCharVector` does not enforce valid UTF-*, but the Arrow specification does specify UTF-8, so it could be confusing for someone who reads this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r464391921
##########
File path: java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestSortingUtil.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.algorithm.sort;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.lang.reflect.Array;
+import java.util.Arrays;
+import java.util.Random;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+
+import org.apache.arrow.vector.BigIntVector;
+import org.apache.arrow.vector.Float4Vector;
+import org.apache.arrow.vector.Float8Vector;
+import org.apache.arrow.vector.IntVector;
+import org.apache.arrow.vector.SmallIntVector;
+import org.apache.arrow.vector.TinyIntVector;
+import org.apache.arrow.vector.ValueVector;
+import org.apache.arrow.vector.VarCharVector;
+import org.apache.arrow.vector.testing.ValueVectorDataPopulator;
+
+/**
+ * Utilities for sorting related utilities.
+ */
+public class TestSortingUtil {
Review comment:
Thank you for the good suggestion.
I have extracted the utility of generating random data to a separate class (RandomDataGenerator). Please check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-674619545
> @liyafan82 any reason why this can't be merged?
@emkornfield I don't think so.
I am going to merge this in a few days, if there is no more comment.
Thank all reviewers for the effort and good comments!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r469660938
##########
File path: java/algorithm/src/main/java/org/apache/arrow/algorithm/sort/VariableWidthOutOfPlaceVectorSorter.java
##########
@@ -45,6 +46,22 @@ public void sortOutOfPlace(V srcVector, V dstVector, VectorValueComparator<V> co
ArrowBuf dstValueBuffer = dstVector.getDataBuffer();
ArrowBuf dstOffsetBuffer = dstVector.getOffsetBuffer();
+ // check buffer size
+ Preconditions.checkArgument(dstValidityBuffer.capacity() * 8 >= srcVector.getValueCount(),
+ "Not enough capacity for the validity buffer of the dst vector. " +
+ "Expected capacity %s, actual capacity %s",
+ (srcVector.getValueCount() + 7) / 8, dstValidityBuffer.capacity());
+ Preconditions.checkArgument(
+ dstOffsetBuffer.capacity() >= srcVector.getValueCount() * BaseVariableWidthVector.OFFSET_WIDTH,
+ "Not enough capacity for the offset buffer of the dst vector. " +
+ "Expected capacity %s, actual capacity %s",
+ srcVector.getValueCount() * BaseVariableWidthVector.OFFSET_WIDTH, dstValueBuffer.capacity());
Review comment:
Nice catch. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r463913775
##########
File path: java/algorithm/src/main/java/org/apache/arrow/algorithm/sort/FixedWidthOutOfPlaceVectorSorter.java
##########
@@ -44,6 +45,13 @@ public void sortOutOfPlace(V srcVector, V dstVector, VectorValueComparator<V> co
ArrowBuf dstValidityBuffer = dstVector.getValidityBuffer();
ArrowBuf dstValueBuffer = dstVector.getDataBuffer();
+ // check buffer size
+ Preconditions.checkArgument(dstValidityBuffer.capacity() * 8 >= srcVector.getValueCount(),
+ "No enough capacity for the validity buffer of the dst vector");
Review comment:
nit: here and other locations "No" -> "Not". It might also pay to include actual values using format strings in the error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-667459724
@liyafan82 one small comment on a typo/better error message otherwise this looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r464392286
##########
File path: java/algorithm/src/main/java/org/apache/arrow/algorithm/sort/FixedWidthOutOfPlaceVectorSorter.java
##########
@@ -44,6 +45,13 @@ public void sortOutOfPlace(V srcVector, V dstVector, VectorValueComparator<V> co
ArrowBuf dstValidityBuffer = dstVector.getValidityBuffer();
ArrowBuf dstValueBuffer = dstVector.getDataBuffer();
+ // check buffer size
+ Preconditions.checkArgument(dstValidityBuffer.capacity() * 8 >= srcVector.getValueCount(),
+ "No enough capacity for the validity buffer of the dst vector");
Review comment:
Good point. Thank you.
I have revised the code accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r461405705
##########
File path: java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestFixedWidthInPlaceVectorSorter.java
##########
@@ -209,4 +212,29 @@ public void testChoosePivotAllPermutes() {
}
}
}
+
+ @Test
+ public void testSortInt2() {
+ try (IntVector vector = new IntVector("vector", allocator)) {
+ ValueVectorDataPopulator.setVector(vector,
+ 0, 1, 2, 3, 4, 5, 30, 31, 32, 33,
+ 34, 35, 60, 61, 62, 63, 64, 65, 6, 7,
+ 8, 9, 10, 11, 36, 37, 38, 39, 40, 41,
+ 66, 67, 68, 69, 70, 71);
+
+ FixedWidthInPlaceVectorSorter sorter = new FixedWidthInPlaceVectorSorter();
+ VectorValueComparator<IntVector> comparator = DefaultVectorComparators.createDefaultComparator(vector);
+
+ sorter.sortInPlace(vector, comparator);
+
+ String actual = "[" + String.join(
+ ", ", IntStream.range(0, vector.getValueCount()).mapToObj(
+ i -> String.valueOf(vector.get(i))).collect(Collectors.toList())) + "]";
+
+ assertEquals(
+ "[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, " +
Review comment:
Revised the code accordingly. Thanks for the good suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r463913435
##########
File path: java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestSortingUtil.java
##########
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.algorithm.sort;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.lang.reflect.Array;
+import java.util.Arrays;
+import java.util.Random;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+
+import org.apache.arrow.vector.BigIntVector;
+import org.apache.arrow.vector.Float4Vector;
+import org.apache.arrow.vector.Float8Vector;
+import org.apache.arrow.vector.IntVector;
+import org.apache.arrow.vector.SmallIntVector;
+import org.apache.arrow.vector.TinyIntVector;
+import org.apache.arrow.vector.ValueVector;
+import org.apache.arrow.vector.VarCharVector;
+import org.apache.arrow.vector.testing.ValueVectorDataPopulator;
+
+/**
+ * Utilities for sorting related utilities.
+ */
+public class TestSortingUtil {
Review comment:
Not necessarily for this PR but factoring out random data generators not specific to sorting would be nice to have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #7837: ARROW-9554: [Java] FixedWidthInPlaceVectorSorter sometimes produces wrong result
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#issuecomment-678870459
Merging this. Thanks to all reviews for the good comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org