You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/08/18 11:46:57 UTC

[GitHub] storm pull request #2809: STORM-3199: Remove metrics-ganglia due to LGPL dep...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2809

    STORM-3199: Remove metrics-ganglia due to LGPL dependency (1.x)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-3199-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2809
    
----
commit 42981a09361e34cac639a867fa32134c76e4cbbc
Author: Stig Rohde Døssing <sr...@...>
Date:   2018-08-16T18:04:11Z

    STORM-3199: Remove metrics-ganglia due to LGPL dependency

----


---

[GitHub] storm issue #2809: STORM-3199: Remove metrics-ganglia due to LGPL dependency...

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2809
  
    Not sure what is happening but 'integration.org.apache.storm.integration-test' is constantly failing for me, and it failed in the travis run too.  I'll try and see if I get the same results on regular 1.x.


---

[GitHub] storm issue #2809: STORM-3199: Remove metrics-ganglia due to LGPL dependency...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2809
  
    @HeartSaVioR Sorry, I didn't get to this in time. I'll try to remember to fix the nits next time there's a PR against 1.x.


---

[GitHub] storm pull request #2809: STORM-3199: Remove metrics-ganglia due to LGPL dep...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2809#discussion_r212838254
  
    --- Diff: pom.xml ---
    @@ -1011,12 +1005,12 @@
                             <groupId>log4j</groupId>
                             <artifactId>log4j</artifactId>
                         </exclusion>
    -                    <exclusion>
    -                        <groupId>org.slf4j</groupId>
    +                   <exclusion>
    --- End diff --
    
    @srdo Looks like some nits on indentation. could you fix them?


---

[GitHub] storm pull request #2809: STORM-3199: Remove metrics-ganglia due to LGPL dep...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2809


---