You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/10/02 18:40:41 UTC
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review186864
-----------------------------------------------------------
Ship it!
I'm going to modify the commit message to mention https://issues.apache.org/jira/browse/MESOS-5450 which is effectively reverted by this patch.
I'll fix the nits below before committing.
src/CMakeLists.txt
Lines 309-317 (original), 309-313 (patched)
<https://reviews.apache.org/r/62106/#comment263710>
Micro-nit: This could be alphabetized.
src/slave/slave.cpp
Line 1060 (original), 1059 (patched)
<https://reviews.apache.org/r/62106/#comment263713>
This comment can also be removed.
src/tests/authentication_tests.cpp
Lines 58-59 (original), 58-59 (patched)
<https://reviews.apache.org/r/62106/#comment263716>
All the TODOs like this can be removed.
src/tests/authentication_tests.cpp
Lines 113-114 (original), 113-114 (patched)
<https://reviews.apache.org/r/62106/#comment263719>
A bit of spacing weirdness is left over.
- Joseph Wu
On Sept. 27, 2017, 12:19 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:19 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, Jie Yu, Joseph Wu, Li Li, and Till Toenshoff.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
> src/sched/sched.cpp 09f255e4affe79b7482ba62efcfa5cf78327735e
> src/slave/slave.cpp 391a0d6db29660d5eb38eab367a2ccf9d453e69d
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
> src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb
> support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
>
>
> Diff: https://reviews.apache.org/r/62106/diff/5/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>