You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/03 06:04:47 UTC

[GitHub] [flink] JingsongLi opened a new pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

JingsongLi opened a new pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756
 
 
   
   ## What is the purpose of the change & Brief change log
   
   - In BinaryHashBucketArea.insertToBucket.
   When BinaryHashTable.buildTableFromSpilledPartition."Build in memory hash table", it requires memory can put all records, if not, will fail.
   Because the linked hash conflict solution, the required memory calculation are not accurate, in this case, we should apply for insufficient memory from heap.
   And must be careful, the steal memory should not return to table.
   
   - In HybridHashTable, first select the corresponding partition according to hashCode, and then select the bucket in the partition according to hashCode, using the same hashCode can easily cause hash collision.
   Consider doing some mix to hashCode when choosing bucket.
   Like JDK HashMap, we can just XOR some shifted bits in the cheapest possible way to reduce systematic lossage, as well as to incorporate impact of the highest bits that would otherwise never be used in index calculations because of table bounds. (bucket use power-of-two masking).  Just like:  (hash ^ (hash >>> 16))
   In some cases, if a lot of conflicts occurred, this will lead to job hang, because hash join will degenerate to nested loop join.
   
   ## Verifying this change
   
   `BinaryHashTableTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142961622 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4106 TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143190671 TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142961622) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063) 
   * ccdd9c9bfa921e64404d8c55d4098588356a9587 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143190671) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142961622 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4106 TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143190671 TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142961622) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063) 
   * ccdd9c9bfa921e64404d8c55d4098588356a9587 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143190671) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TsReaper removed a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
TsReaper removed a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-571473775
 
 
   Thanks @JingsongLi for the commit. Looks good to me +1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] liyafan82 commented on a change in pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on a change in pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#discussion_r362764978
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/hashtable/BaseHybridHashTable.java
 ##########
 @@ -516,4 +511,10 @@ public static int hash(int hashCode, int level) {
 		return code >= 0 ? code : -(code + 1);
 	}
 
+	/**
+	 * Partition level hash again, for avoid two layer hash conflict.
+	 */
+	static int partitionLevelHash(int hash) {
+		return hash ^ (hash >>> 16);
+	}
 
 Review comment:
   @JingsongLi Thanks a lot for bringing this up. 
   I agree with you that this is computationally efficient. 
   
   However, according to my experince, this may not be a good hash function. In practice, we usually encounter small integers (with most high bits equal to 0), so we have hash >>> 16 == 0, and hash ^ (hash >>> 16) will be equal to hash.
   
   IMO, hash ^ (hash << 16) is much better, as it maps small integers uniformly into the space of all integers. 
   
   That being that, this is just my personal suggestion. The final choice should be dependent on the real scenario. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142961622 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4106 TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143190671 TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142961622) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063) 
   * ccdd9c9bfa921e64404d8c55d4098588356a9587 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143190671) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142961622 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:ccdd9c9bfa921e64404d8c55d4098588356a9587 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ccdd9c9bfa921e64404d8c55d4098588356a9587
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142961622) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063) 
   * ccdd9c9bfa921e64404d8c55d4098588356a9587 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TsReaper commented on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
TsReaper commented on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-571473775
 
 
   Thanks @JingsongLi for the commit. Looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix required memory calculation not accurate and hash collision bugs in hash table

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix required memory calculation not accurate and hash collision bugs in hash table
URL: https://github.com/apache/flink/pull/10756
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#discussion_r363143078
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/hashtable/BaseHybridHashTable.java
 ##########
 @@ -516,4 +511,10 @@ public static int hash(int hashCode, int level) {
 		return code >= 0 ? code : -(code + 1);
 	}
 
+	/**
+	 * Partition level hash again, for avoid two layer hash conflict.
+	 */
+	static int partitionLevelHash(int hash) {
+		return hash ^ (hash >>> 16);
+	}
 
 Review comment:
   Thanks for involving this.
   > with most high bits equal to 0
   
   Good point, but it should not. 
   - In `BinaryHashTable`: HashCode is from murmurhash, it is good.
   - In `LongHybridHashTable`: HashCode is from `hashLong`, it is good too.
   
   `hash ^ (hash >>> 16)` is just from `HashMap.hash`, I think it is OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TsReaper edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
TsReaper edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-571473775
 
 
   Thanks @JingsongLi for the commit. Looks good to me +1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142961622 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142961622) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570474072
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 82ff8a76280af02f98613526b8b309ae6d4f2e94 (Fri Jan 03 06:08:25 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-11964).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10756: [FLINK-15465][FLINK-11964][table-runtime-blink] Fix hash table bugs
URL: https://github.com/apache/flink/pull/10756#issuecomment-570475001
 
 
   <!--
   Meta data
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142961622 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   Hash:82ff8a76280af02f98613526b8b309ae6d4f2e94 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063 TriggerType:PUSH TriggerID:82ff8a76280af02f98613526b8b309ae6d4f2e94
   -->
   ## CI report:
   
   * 82ff8a76280af02f98613526b8b309ae6d4f2e94 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142961622) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4063) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services