You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/01 00:33:51 UTC
[jira] [Commented] (HIVE-2380) Add Binary Datatype in Hive

    [ https://issues.apache.org/jira/browse/HIVE-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118527#comment-13118527 ] 

jiraposter@reviews.apache.org commented on HIVE-2380:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1586/#review2239
-----------------------------------------------------------


Looking good (added a note for one missing ORDER BY remaining).

But regarding "10111111", I don't think we should have any corner cases at all in the set of binary strings which can be stored.  That would just be a land mine.  Can you think of a solution?



trunk/ql/src/test/queries/clientpositive/ba_table_union.q
<https://reviews.apache.org/r/1586/#comment5195>

    Need ORDER BY.


- John


On 2011-09-30 17:37:25, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1586/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-30 17:37:25)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This patch adds bytearray as a new datatype in Hive.
bq.  
bq.  
bq.  This addresses bug HIVE-2380.
bq.      https://issues.apache.org/jira/browse/HIVE-2380
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConcat.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLength.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java 1177528 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToBinary.java PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_1.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_2.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_3.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_4.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_5.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_6.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_1.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_2.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_3.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_4.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_5.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_6.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/ba_table1.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/ba_table2.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/ba_table3.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/ba_table_udfs.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/ba_table_union.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/binary_table_bincolserde.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/binary_table_colserde.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/load_binary_data.q PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_1.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_2.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_3.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_4.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_5.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_6.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_1.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_2.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_3.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_4.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_5.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_6.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/ba_table1.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/ba_table2.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/ba_table3.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/ba_table_udfs.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/ba_table_union.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/binary_table_bincolserde.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/binary_table_colserde.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/load_binary_data.q.out PRE-CREATION 
bq.    trunk/serde/if/serde.thrift 1177528 
bq.    trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1177528 
bq.    trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1177528 
bq.    trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java 1177528 
bq.    trunk/serde/src/gen/thrift/gen-php/serde/serde_constants.php 1177528 
bq.    trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 1177528 
bq.    trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBinaryObjectInspector.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryBinary.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/BinaryObjectInspector.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaBinaryObjectInspector.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 1177528 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableBinaryObjectInspector.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableBinaryObjectInspector.java PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestStatsSerde.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLazyBinaryColumnarSerDe.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassBigger.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java 1177528 
bq.    trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 1177528 
bq.  
bq.  Diff: https://reviews.apache.org/r/1586/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added and updated unit tests.
bq.  Added new system tests.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.


                
> Add Binary Datatype in Hive
> ---------------------------
>
>                 Key: HIVE-2380
>                 URL: https://issues.apache.org/jira/browse/HIVE-2380
>             Project: Hive
>          Issue Type: New Feature
>          Components: Serializers/Deserializers
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-2380.patch, hive-2380_1.patch, hive-2380_2.patch
>
>
> Add bytearray as a primitive data type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira