You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 22:46:38 UTC
[PR] [ISSUE-3839][test] Deepen AlertServiceDefaultRulesTest with repository-rule export and disabled filtering [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3839:
URL: https://github.com/apache/rocketmq-dashboard/pull/3839
### Motivation
The existing `AlertServiceDefaultRulesTest` covers the fallback to bundled assets only. The repository-driven export path (rules actually stored in the repository) and the enabled filtering before the fallback were untested.
### Changes
- `exportUsesRepositoryRulesWhenPresentTest`: a stored, enabled business rule is rendered into the Prometheus YAML with its alert name, expression and threshold.
- `exportFiltersDisabledRulesBeforeFallingBackToDefaultsTest`: a disabled rule is filtered out so the export falls back to the bundled default assets.
### Verification
```
mvn -B test -Dtest=AlertServiceDefaultRulesTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE-3839][test] Deepen AlertServiceDefaultRulesTest with repository-rule export and disabled filtering [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3839: [ISSUE-3839][test] Deepen AlertServiceDefaultRulesTest with repository-rule export and disabled filtering
URL: https://github.com/apache/rocketmq-dashboard/pull/3839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org