You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "simbit18 (via GitHub)" <gi...@apache.org> on 2025/11/14 14:16:20 UTC
[PR] tools/checkpatch.sh: Improved error display on GitHub [nuttx]
simbit18 opened a new pull request, #17335:
URL: https://github.com/apache/nuttx/pull/17335
## Summary
The improvement includes symbols that help employees visualise any errors detected during the PR check phase (check.yml).
Error -> ❌ U+274C Cross Mark
https://en.wikipedia.org/wiki/X_mark
Checks pass -> ✔️ U+2714 Heavy Check Mark
https://en.wikipedia.org/wiki/Check_mark
These characters are emojis that are recognized by the Unicode standards which define what each character represents.
## Impact
Impact on user: NO
Impact on build: NO
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
## Testing
GitHub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/checkpatch.sh: Improved error display on GitHub [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #17335:
URL: https://github.com/apache/nuttx/pull/17335#issuecomment-3533309361
> Nice improvement!!!
>
> BTW, maybe for Check you could consider U+2705 because the color used for V check on github is very "pale"
@acassis But what we're interested in is fiery red ! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/checkpatch.sh: Improved error display on GitHub [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #17335:
URL: https://github.com/apache/nuttx/pull/17335#issuecomment-3533318952
> > Nice improvement!!!
> > BTW, maybe for Check you could consider U+2705 because the color used for V check on github is very "pale"
>
> @acassis But what we're interested in is fiery red ! :)
Yes, I agree, it is just an aesthetic suggestion ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/checkpatch.sh: Improved error display on GitHub [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #17335:
URL: https://github.com/apache/nuttx/pull/17335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org