[jira] [Commented] (ZOOKEEPER-1610) Some classes are using == or != to compare Long/String objects instead of .equals()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792822#comment-13792822 ] 

Hadoop QA commented on ZOOKEEPER-1610:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12562389/ZOOKEEPER-1610.patch
  against trunk revision 1531061.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1680//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1680//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1680//console

This message is automatically generated.

> Some classes are using == or != to compare Long/String objects instead of .equals()
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1610
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1610
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client, quorum
>    Affects Versions: 3.4.5, 3.5.0
>            Reporter: Edward Ribeiro
>            Assignee: Edward Ribeiro
>            Priority: Critical
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1610.patch
>
>
> The classes org.apache.zookeeper.client.ZooKeeperSaslClient.java and 
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.java compare Strings and/or Longs using referential equality.
> Usually, this is not a problem because the Longs are cached and Strings are interned, but I myself  had problems with those kind of comparisons in the past because one production JVM didn't reused the objects.



--
This message was sent by Atlassian JIRA
(v6.1#6144)