You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/09 19:18:55 UTC

[GitHub] [airflow] ryanahamilton opened a new issue #14154: Add/enforce ESLint (JavaScript linting) in pre-commit hooks

ryanahamilton opened a new issue #14154:
URL: https://github.com/apache/airflow/issues/14154


   There is already an existing ESLint configuration and supporting `yarn lint` commands, it just needs to be integrated into pre-commit.
   
   This will prevent errors and ensure consistent style/syntax is utilized throughout the codebase.
   
   I made a previous attempt at resolving it several months ago in #11699. While I had it working locally, I was unable to get it executing properly in our CI environment.
   
   **Related Issues**
   
   We're working on migrating our inline JavaScript to external files (#14115). I'm not sure that is a pre-requisite for this issue, but the order of execution will certainly affect the scope.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb closed issue #14154: Add/enforce ESLint (JavaScript linting) in pre-commit hooks

Posted by GitBox <gi...@apache.org>.
ashb closed issue #14154:
URL: https://github.com/apache/airflow/issues/14154


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org