[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2246: HDDS-5209. Datanode hasEnoughSpace check should apply on volume instead of global DN

[GitBox <gi...@apache.org>]

JacksonYao287 commented on a change in pull request #2246:
URL: https://github.com/apache/ozone/pull/2246#discussion_r632413608



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java
##########
@@ -165,9 +166,15 @@ public ConfigurationSource getConf() {
    */
   public boolean hasEnoughSpace(DatanodeDetails datanodeDetails,
       long sizeRequired) {
-    SCMNodeMetric nodeMetric = nodeManager.getNodeStat(datanodeDetails);
-    return (nodeMetric != null) && (nodeMetric.get() != null)
-        && nodeMetric.get().getRemaining().hasResources(sizeRequired);
+    if (datanodeDetails instanceof DatanodeInfo) {

Review comment:
       Thanks @guihecheng for this work!
   i have a little question, is there existing a situation that a `datanodeDetails` is not an instance of `DatanodeInfo`, but the corresponding datanode does have a volume that has enough space for the requirement?
   if no, then every `datanodeDetails` is an instance of  `DatanodeInfo`, so can we deprecate `datanodeDetails` and only use `DatanodeInfo`?
   if yes, will this lead to a misjudgegment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org