[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9809: [feature-wip](array-type) Support array type which doesn't contain null

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #9809:
URL: https://github.com/apache/incubator-doris/pull/9809#discussion_r886856398


##########
gensrc/thrift/Types.thrift:
##########
@@ -126,6 +126,9 @@ struct TTypeNode {
 
     // only used for structs; has struct_fields.size() corresponding child types
     3: optional list<TStructField> struct_fields
+
+    // only used for complex types, such as array, map and etc.
+    4: optional bool contains_null

Review Comment:
   use is_null or is_nullable instead of contains_null;
   
   is_null means current scalar_type is null or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org