You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/11/03 20:30:15 UTC

[GitHub] [daffodil] tuxji commented on a change in pull request #673: Raise minimum C level to ISO C11 with GNU extensions

tuxji commented on a change in pull request #673:
URL: https://github.com/apache/daffodil/pull/673#discussion_r742306694



##########
File path: daffodil-runtime2/src/test/resources/org/apache/daffodil/runtime2/examples/NestedUnion/generated_code.c
##########
@@ -365,7 +368,7 @@ data_parseSelf(data *instance, PState *pstate)
         break;
     default:
         // Should never happen because initChoice would return an error first
-        error.d64 = (int64_t)instance->_choice;
+        error.arg.d64 = (int64_t)instance->_choice;

Review comment:
       I changed that struct in a C portability fix commit that went in last May...
   
   <https://github.com/apache/daffodil/commit/8c95b39f5e365ae15657bcdc4686b44689b1fbb9#diff-6df97fc1bdf91db52173653361b5a40e5e075b80312a69912aa23e141dad57c6>
   
   However, these "example" generated code files aren't updated automatically, so I didn't re-generate this example file until now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org