You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/14 20:27:57 UTC

[GitHub] [incubator-druid] jennyzzz opened a new pull request #7657: Deleted created_time in "status"

jennyzzz opened a new pull request #7657: Deleted created_time in "status"
URL: https://github.com/apache/incubator-druid/pull/7657
 
 
   This PR fixes the following issues:
   Druid console shows blank screen when clicking on Tasks > group by Datasource (> or group by Type) (https://github.com/implydata/imply-dev/issues/362)
   Tasks view group by status only shows 1 status (https://github.com/implydata/imply-dev/issues/393)
   
   Current UI:
   it can be grouped by type:
   ![image](https://user-images.githubusercontent.com/10763823/57729770-d6360500-764b-11e9-9be1-f64c8b4d86b8.png)
   
   Or grouped by status:
   ![image](https://user-images.githubusercontent.com/10763823/57729816-eea61f80-764b-11e9-9e2d-9ce508e00222.png)
   
   
   
   Changed the status `accessor` to `row.status` only, because this `ReactTable` doesn't support object pivoting. 
   It seems the reason why `created_time` was included in this column `accessor` is for sorting only. If so, we can  use multi-sort (https://github.com/tannerlinsley/react-table/tree/v6#multi-sort) as an alternative.
   
   > When clicking on a column header, hold shift to multi-sort! You can toggle ascending descending and none for multi-sort columns. Clicking on a header without holding shift will clear the multi-sort and replace it with the single sort of that column. It's quite handy!
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org