[GitHub] nifi-minifi-cpp pull request #372: MINIFICPP-557: Previously the empty flag ...

[phrocker <gi...@git.apache.org>]

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/372

    MINIFICPP-557: Previously the empty flag was not a necessary check as…

    … we didn't
    
    have the case where empty ValueNodes could or should occur ( and these were dealt with elsewhere)
    but recent changes have made this a new requirement thus we can add the empty check
    for validation of lists.
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-557

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #372
    
----
commit 15ab090b3148456ca5e52aa1b79de1df5cf8badc
Author: Marc Parisi <ph...@...>
Date:   2018-07-16T18:22:24Z

    MINIFICPP-557: Previously the empty flag was not a necessary check as we didn't
    have the case where empty ValueNodes could or should occur ( and these were dealt with elsewhere)
    but recent changes have made this a new requirement thus we can add the empty check
    for validation of lists.

----


---

[GitHub] nifi-minifi-cpp issue #372: MINIFICPP-557: Previously the empty flag was not...

[apiri <gi...@git.apache.org>]

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/372
  
    these changes look good.  was able to verify the issue was remedied.  will merge. thanks!


---

[GitHub] nifi-minifi-cpp issue #372: MINIFICPP-557: Previously the empty flag was not...

[phrocker <gi...@git.apache.org>]

Github user phrocker commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/372
  
    @apiri feel free to try this 


---

[GitHub] nifi-minifi-cpp issue #372: MINIFICPP-557: Previously the empty flag was not...

[apiri <gi...@git.apache.org>]

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/372
  
    reviewing


---

[GitHub] nifi-minifi-cpp pull request #372: MINIFICPP-557: Previously the empty flag ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/372


---