You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/08/12 14:53:43 UTC

[GitHub] brooklyn-ui pull request #31: show tabs in CM editor

GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/31

    show tabs in CM editor

    based on https://codemirror.net/demo/visibletabs.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-ui visible-tabs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 0d601f5bc93f1c0b7370739f06a23db33eaea1ea
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2016-08-12T14:53:45Z

    show tabs in CM editor
    
    based on https://codemirror.net/demo/visibletabs.html

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui issue #31: show tabs in CM editor

Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/31
  
    LGTM / Tested


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui issue #31: show tabs in CM editor

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/31
  
    This just makes them visible as in the link above.  We should give a better error message and go to the location but this super-easy fix will help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui pull request #31: show tabs in CM editor

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-ui/pull/31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-ui issue #31: show tabs in CM editor

Posted by shartzel <gi...@git.apache.org>.
Github user shartzel commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/31
  
    good idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---