[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #16: feature k210

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362002179
 
 

 ##########
 File path: include/stdint.h
 ##########
 @@ -273,8 +273,13 @@ typedef _uint64_t           uint_fast64_t;
 
 /* Integer types capable of holding object pointers */
 
+#ifdef __LP64__
+typedef long                intptr_t;
+typedef unsigned long       uintptr_t;
+#else
 typedef _intptr_t           intptr_t;
 typedef _uintptr_t          uintptr_t;
+#endif
 
 
 Review comment:
   I don't believe that this is a correct change.  You chould not put any CPU specific definitions in the POSIX standard stdint.h.  That is the wrong way to go.
   
   Instead, you need to change arch/risc-v/include/types.h.  That is the appropriate place for this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services