You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/11/12 08:46:30 UTC
[kudu-CR] www: add tablets count and on disk size on /tables
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14694
Change subject: www: add tablets count and on_disk size on /tables
......................................................................
www: add tablets count and on_disk size on /tables
Add tablets count and on_disk size on /tables so that
we could easily find oversize tables when there are
many tables in a cluster.
Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
---
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/14694/1
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] www: add tablet count and on disk size on /tables
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14694
to look at the new patch set (#4).
Change subject: www: add tablet_count and on_disk_size on /tables
......................................................................
www: add tablet_count and on_disk_size on /tables
Add tablet_count and on_disk_size on /tables so that
we could easily find oversize tables when there are
many tables in a cluster.
Screenshot: http://ww1.sinaimg.cn/large/9b7ebaddly1g8vfrqxmpgj21eq0aodi6.jpg
Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
---
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
2 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/14694/4
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] www: add tablets count and on disk size on /tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablets count and on_disk size on /tables
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
PS1:
For consistency, let's avoid JSON variables with spaces in them. Use underscores instead.
http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc@266
PS1, Line 266: vector<scoped_refptr<TabletInfo>> tablets;
: table->GetAllTablets(&tablets);
: table_json["tablets count"] = Substitute("$0", tablets.size());
Could call table->num_tablets() instead.
http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache
File www/tables.mustache:
http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache@38
PS1, Line 38: leaders only
Do you think "pre-replication" is clearer?
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 08:54:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] www: add tablet count and on disk size on /tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablet_count and on_disk_size on /tables
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 21:21:54 +0000
Gerrit-HasComments: No
[kudu-CR] www: add tablet count and on disk size on /tables
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14694
to look at the new patch set (#3).
Change subject: www: add tablet_count and on_disk_size on /tables
......................................................................
www: add tablet_count and on_disk_size on /tables
Add tablet_count and on_disk_size on /tables so that
we could easily find oversize tables when there are
many tables in a cluster.
Screenshots: http://ww1.sinaimg.cn/large/9b7ebaddly1g8vfrqxmpgj21eq0aodi6.jpg
Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
---
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
2 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/14694/3
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] www: add tablet count and on disk size on /tables
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablet_count and on_disk_size on /tables
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14694/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14694/2//COMMIT_MSG@9
PS2, Line 9: Add tablet_count and on_disk_size
> Nit: "Add tablet_count and on_disk_size"
Done
http://gerrit.cloudera.org:8080/#/c/14694/2/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/14694/2/src/kudu/master/master_path_handlers.cc@266
PS2, Line 266: table_json["tablet_count"] = HumanReadableInt::ToString(table->num_tablets());
> Maybe HumanReadableInt here?
Done
http://gerrit.cloudera.org:8080/#/c/14694/2/www/tables.mustache
File www/tables.mustache:
http://gerrit.cloudera.org:8080/#/c/14694/2/www/tables.mustache@37
PS2, Line 37: Tablet Count<
> Nit: Tablet Count
Done
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 10:46:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] www: add tablet count and on disk size on /tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablet_count and on_disk_size on /tables
......................................................................
www: add tablet_count and on_disk_size on /tables
Add tablet_count and on_disk_size on /tables so that
we could easily find oversize tables when there are
many tables in a cluster.
Screenshot: http://ww1.sinaimg.cn/large/9b7ebaddly1g8vfrqxmpgj21eq0aodi6.jpg
Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Reviewed-on: http://gerrit.cloudera.org:8080/14694
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] www: add tablets count and on disk size on /tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablets count and on_disk size on /tables
......................................................................
Patch Set 2:
One other request: could you upload a screenshot somewhere showing the tables page in action, then share the link here?
Better yet, include the link in your commit message (provided it's a permalink).
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 10:02:31 +0000
Gerrit-HasComments: No
[kudu-CR] www: add tablets count and on disk size on /tables
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablets count and on_disk size on /tables
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
PS1:
> For consistency, let's avoid JSON variables with spaces in them. Use unders
Done
http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc@266
PS1, Line 266: table_json["tablets_count"] = Substitute("$0", table->num_tablets());
: const TableMetrics* table_metrics = table->GetMetrics();
: if (table_metrics) {
> Could call table->num_tablets() instead.
Done
http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache
File www/tables.mustache:
http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache@38
PS1, Line 38: pre-replicat
> Do you think "pre-replication" is clearer?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 09:54:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] www: add tablets count and on disk size on /tables
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14694
to look at the new patch set (#2).
Change subject: www: add tablets count and on_disk size on /tables
......................................................................
www: add tablets count and on_disk size on /tables
Add tablets count and on_disk size on /tables so that
we could easily find oversize tables when there are
many tables in a cluster.
Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
---
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
2 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/14694/2
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] www: add tablets count and on disk size on /tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablets count and on_disk size on /tables
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14694/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14694/2//COMMIT_MSG@9
PS2, Line 9: Add tablets count and on_disk size
Nit: "Add tablet_count and on_disk_size"
On L7 too.
http://gerrit.cloudera.org:8080/#/c/14694/2/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/14694/2/src/kudu/master/master_path_handlers.cc@266
PS2, Line 266: table_json["tablets_count"] = Substitute("$0", table->num_tablets());
Maybe HumanReadableInt here?
Also nit: tablet_count
http://gerrit.cloudera.org:8080/#/c/14694/2/www/tables.mustache
File www/tables.mustache:
http://gerrit.cloudera.org:8080/#/c/14694/2/www/tables.mustache@37
PS2, Line 37: Tablets Count
Nit: Tablet Count
--
To view, visit http://gerrit.cloudera.org:8080/14694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 10:01:36 +0000
Gerrit-HasComments: Yes