You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "nkeywal (Created) (JIRA)" <ji...@apache.org> on 2012/04/01 13:10:34 UTC
[jira] [Created] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
When creating a region, the master initializes it and creates a memstore within the master server
-------------------------------------------------------------------------------------------------
Key: HBASE-5693
URL: https://issues.apache.org/jira/browse/HBASE-5693
Project: HBase
Issue Type: Improvement
Components: master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245006#comment-13245006 ]
Hudson commented on HBASE-5693:
-------------------------------
Integrated in HBase-TRUNK-security #156 (See [https://builds.apache.org/job/HBase-TRUNK-security/156/])
HBASE-5693 When creating a region, the master initializes it and creates a memstore within the master server (Revision 1308535)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5693:
---------------------------
Status: Open (was: Patch Available)
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243853#comment-13243853 ]
stack commented on HBASE-5693:
------------------------------
+1 on patch. Its silly we initialize the region over on master on creation.
bq. CreateTableHandler isn't initializing the regions. Who will initialize them ?
The regionserver when its assigned a region.
bq. May be there is some thing more complex I didn't see, but at least all the unit tests went well.
Nothing complex here.
Regards test on a real cluster, not necessary on a patch this small. Unit tests run clusters anyways.
Please make a patch that applies N and run it by hadoopqa. Thanks.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244956#comment-13244956 ]
stack commented on HBASE-5693:
------------------------------
You could but benefit is little, probably not worth the risk.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244829#comment-13244829 ]
Hudson commented on HBASE-5693:
-------------------------------
Integrated in HBase-TRUNK #2704 (See [https://builds.apache.org/job/HBase-TRUNK/2704/])
HBASE-5693 When creating a region, the master initializes it and creates a memstore within the master server (Revision 1308535)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244953#comment-13244953 ]
Lars Hofhansl commented on HBASE-5693:
--------------------------------------
For 0.94?
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5693:
---------------------------
Status: Patch Available (was: Open)
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5693:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I tried the first three locally. They pass for me. Committed trunk. Thanks for the patch N.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5693:
---------------------------
Attachment: 5593.v2.patch
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244495#comment-13244495 ]
stack commented on HBASE-5693:
------------------------------
The failures because of your patch N?
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5693:
---------------------------
Attachment: 5693.v1.patch
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244021#comment-13244021 ]
Hadoop QA commented on HBASE-5693:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520876/5593.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSide
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1364//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1364//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1364//console
This message is automatically generated.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243746#comment-13243746 ]
Ted Yu commented on HBASE-5693:
-------------------------------
CreateTableHandler isn't initializing the regions.
Who will initialize them ?
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243762#comment-13243762 ]
Ted Yu commented on HBASE-5693:
-------------------------------
It is called from OpenRegionHandler.openRegion()
I once made some threads daemon which passed unit tests but resulted in master and region server failing to start.
Testing on a real cluster is desirable.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5693:
-------------------------
Fix Version/s: 0.94.4
Committed to 0.94 as part of HBASE-7253
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511090#comment-13511090 ]
Hudson commented on HBASE-5693:
-------------------------------
Integrated in HBase-0.94 #611 (See [https://builds.apache.org/job/HBase-0.94/611/])
HBASE-7253 Backport Compaction Tool to 0.94; includes HBASE-5616, HBASE-5693, HBASE-6327, HBASE-7253 (Revision 1417559)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Compactor.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243836#comment-13243836 ]
Hadoop QA commented on HBASE-5693:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520822/5693.v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1358//console
This message is automatically generated.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243775#comment-13243775 ]
nkeywal commented on HBASE-5693:
--------------------------------
Ok, I will do that + a test on a real cluster.
On Sun, Apr 1, 2012 at 6:12 PM, Ted Yu (Commented) (JIRA)
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243751#comment-13243751 ]
nkeywal commented on HBASE-5693:
--------------------------------
I didn't look very far in the code. CreateTableHandler is executed on the
master. It does not need to initialize the memstore & so on.
The underlying method is called from the region server as well; and here
the initialization code is called. May be there is some thing more complex
I didn't see, but at least all the unit tests went well.
On Sun, Apr 1, 2012 at 5:28 PM, Ted Yu (Commented) (JIRA)
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244519#comment-13244519 ]
nkeywal commented on HBASE-5693:
--------------------------------
I don't think so. I didn't see them locally.
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243765#comment-13243765 ]
Ted Yu commented on HBASE-5693:
-------------------------------
@N:
Can you rebased the patch for trunk ?
{code}
Hunk #3 FAILED at 3613.
1 out of 3 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java.rej
{code}
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5693:
---------------------------
Status: Patch Available (was: Open)
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5693) When creating a region, the master
initializes it and creates a memstore within the master server
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5693:
-------------------------
Committed to 0.94 as part of HBASE-7253
> When creating a region, the master initializes it and creates a memstore within the master server
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-5693
> URL: https://issues.apache.org/jira/browse/HBASE-5693
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 5593.v2.patch, 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each region creation and locally all the unit tests work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira