You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/23 23:33:56 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7957: Fixed segment upload error return

Jackie-Jiang commented on a change in pull request #7957:
URL: https://github.com/apache/pinot/pull/7957#discussion_r774811569



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -308,7 +308,7 @@ private SuccessResponse uploadSegment(@Nullable String tableName, TableType tabl
       throw e;
     } catch (Exception e) {
       _controllerMetrics.addMeteredGlobalValue(ControllerMeter.CONTROLLER_SEGMENT_UPLOAD_ERROR, 1L);
-      throw new ControllerApplicationException(LOGGER, "Caught internal server exception while uploading segment",
+      throw new ControllerApplicationException(LOGGER, "Exception while uploading segment:" + e.getMessage(),

Review comment:
       (minor)
   ```suggestion
         throw new ControllerApplicationException(LOGGER, "Exception while uploading segment: " + e.getMessage(),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org