You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (JIRA)" <ji...@apache.org> on 2017/10/08 16:34:00 UTC

[jira] [Commented] (SPARK-17169) To use scala macros to update code when SharedParamsCodeGen.scala changed

    [ https://issues.apache.org/jira/browse/SPARK-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196206#comment-16196206 ] 

Hyukjin Kwon commented on SPARK-17169:
--------------------------------------

[~josephkb], should we maybe leave this as {{Won't Fix}} or {{Later}} if you don't think it is worthwhile and there is no explicit objection against this (it looks so)?

> To use scala macros to update code when SharedParamsCodeGen.scala changed
> -------------------------------------------------------------------------
>
>                 Key: SPARK-17169
>                 URL: https://issues.apache.org/jira/browse/SPARK-17169
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Qian Huang
>            Priority: Minor
>
> As commented in the file SharedParamsCodeGen.scala, we have to manually run
> build/sbt "mllib/runMain org.apache.spark.ml.param.shared.SharedParamsCodeGen"
> to generate and update it.
> It could be better to do compile time code-gen for this using scala macros rather than running the script as described above. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org