You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/18 07:41:41 UTC

[GitHub] [incubator-nuttx] jlaitine opened a new pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

jlaitine opened a new pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776


   …for mpfs target
   
   This is partial revert of
   807304f2835e4d70eb2581b15b447582ad009aea arch/risc-v: Rework riscv_get_newintctx
   
   The original patch causes the mpfs stop booting. Using whatever happens to be in
   CSR as the initial status is just not right.
   
   Signed-off-by: Jukka Laitinen <ju...@ssrc.tii.ae>
   
   ## Summary
   
   Fix an erroneous intial context
   
   ## Impact
   
   This restores MPFS target to work again
   
   ## Testing
   
   Tested on Microchip PolarFire SOC FPGA based target
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072125196






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072192316


   Yes, it's not the best solution since you can modify the mstatus by context, but for these preserved bits we don't known its default value so it's hard to assign the flags explicitly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine closed pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine closed pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine edited a comment on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine edited a comment on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072158030


   yes, will do. Keep this one on hold still.
   
   But in general; if you want to preserve the reserved bits, maybe these should be preserved explicitly and others be set. I don't think that it is a good idea to preserve the other bits of the CSR than the reserved ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine commented on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072203674


   The issue is fixed in #5775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072125196


   Hmm , sorry for this issue, could you try #5775 on your target ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine commented on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072158030


   yes, will do. Keep this one on hold still.
   
   But in general; if you want to preserve the reserved bits, maybe these should be preserved explicitly and others be set. I don't think that it is a good idea to preserve the other bits CSR than the reserved ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine edited a comment on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine edited a comment on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072158030


   yes, will do. Keep this one on hold still.
   
   But in general; if you want to preserve the reserved bits, maybe these should be preserved explicitly and others be set. I don't think that it is a good idea to preserve the other bits of the CSR than the reserved ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine commented on pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776#issuecomment-1072158030






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine closed pull request #5776: arch/risc-v/src/mpfs/mpfs_irq.c: Revert "Rework riscv_get_newintctx" …

Posted by GitBox <gi...@apache.org>.
jlaitine closed pull request #5776:
URL: https://github.com/apache/incubator-nuttx/pull/5776


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org