You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:58:04 UTC
[GitHub] [airflow] eeshugerman opened a new pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
eeshugerman opened a new pull request #9182:
URL: https://github.com/apache/airflow/pull/9182
If `Variable`s are used in DAGs, and Postgres is used for the internal
database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the
logs with error messages (but does not fail).
This commit corrects this by running each migration in a separate
transaction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #9182:
URL: https://github.com/apache/airflow/pull/9182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eeshugerman commented on pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
Posted by GitBox <gi...@apache.org>.
eeshugerman commented on pull request #9182:
URL: https://github.com/apache/airflow/pull/9182#issuecomment-641595881
:+1: I see, thanks, I was wondering how that works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eeshugerman commented on pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
Posted by GitBox <gi...@apache.org>.
eeshugerman commented on pull request #9182:
URL: https://github.com/apache/airflow/pull/9182#issuecomment-641534402
This is already in `master`. I'm trying to backport to v1.10. Please see the discussion here: https://github.com/apache/airflow/pull/4797
(Sorry for the confusion, I should have added a note of explanation to these.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #9182:
URL: https://github.com/apache/airflow/pull/9182#issuecomment-641543813
Ah, we don't need a PR in this case -- just marking the original PR for the milestone 1.10.11 is enough and we'd cherry pick it.
Since you've got it opened I'll merge this though.
(We like cherry-picks to have the "(cherry picked from commit ...)" footer that `-x` adds, and our tooling to work out which commits are yet to be backported for a release relies upon the `(#<PR>)` on the end of the commit, so I have manually done both of these for this PR.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9182:
URL: https://github.com/apache/airflow/pull/9182#issuecomment-641543813
Ah, we don't need a PR in this case -- just marking the original PR for the milestone 1.10.11 is enough and we'd cherry pick it.
Since you've got it opened I'll merge this though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9182: [AIRFLOW-3973] Commit after each alembic migration
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9182:
URL: https://github.com/apache/airflow/pull/9182#issuecomment-641497817
As mentioned in our other PR https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#airflow-git-branches -- this PR needs to target master, not v1-10-test/stable please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org