You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/09 03:13:19 UTC
[GitHub] [incubator-seatunnel] wfrong opened a new pull request, #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
wfrong opened a new pull request, #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897
## Purpose of this pull request
Unifie InfluxDB source fields to schema
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1067097614
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -25,7 +25,7 @@ supports query SQL and can achieve projection effect.
|--------------------|--------|----------|---------------|
| url | string | yes | - |
| sql | string | yes | - |
-| fields | config | yes | - |
+| schema | object | yes | - |
Review Comment:
```suggestion
| schema | config | yes | - |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wfrong commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
wfrong commented on PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1376762255
cc @Hisoka-X @liugddx , could you help me review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wfrong commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
wfrong commented on PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1378167653
> > cc @Hisoka-X @liugddx , could you help me review this PR?
> > Let's wait for CI.
I have resolved e2e module CI error , could you please restart CI ？thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wfrong commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
wfrong commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1070790599
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -25,7 +25,7 @@ supports query SQL and can achieve projection effect.
|--------------------|--------|----------|---------------|
| url | string | yes | - |
| sql | string | yes | - |
-| fields | config | yes | - |
+| schema | object | yes | - |
Review Comment:
>
thanks @liugddx for your advise, I have updated the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wfrong commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
wfrong commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071695478
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -51,19 +51,20 @@ The query sql used to search data
select name,age from test
```
-### fields [string]
+### schema [config]
Review Comment:
> Please add change log to this doc and https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md
Thanks for your suggestions！I have done this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071283553
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -51,19 +51,20 @@ The query sql used to search data
select name,age from test
```
-### fields [string]
+### schema [config]
Review Comment:
Please add change log to this doc and https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071767538
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -51,19 +51,20 @@ The query sql used to search data
select name,age from test
```
-### fields [string]
+### schema [config]
-the fields of the InfluxDB when you select
-
-the field type is SeaTunnel field type `org.apache.seatunnel.api.table.type.SqlType`
+#### fields [Config]
Review Comment:
My fault. There is no problem with the modifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wfrong commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
wfrong commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071766440
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -51,19 +51,20 @@ The query sql used to search data
select name,age from test
```
-### fields [string]
+### schema [config]
-the fields of the InfluxDB when you select
-
-the field type is SeaTunnel field type `org.apache.seatunnel.api.table.type.SqlType`
+#### fields [Config]
Review Comment:
> Maybe you need to check in detail.
Thanks for your suggestions!
But in my opinion, maybe this line should not be changed, beacuse schema and fields at different levels,like the first picture.
either or do you mean that just remove this line, like the second picture?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1384137584
#3896 is duplicate with this. In chronological order #3896 is valid, could you please try another task? @wfrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071696113
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -51,19 +51,20 @@ The query sql used to search data
select name,age from test
```
-### fields [string]
+### schema [config]
-the fields of the InfluxDB when you select
-
-the field type is SeaTunnel field type `org.apache.seatunnel.api.table.type.SqlType`
+#### fields [Config]
Review Comment:
```suggestion
#### schema [Config]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071696563
##########
docs/en/connector-v2/source/InfluxDB.md:
##########
@@ -51,19 +51,20 @@ The query sql used to search data
select name,age from test
```
-### fields [string]
+### schema [config]
-the fields of the InfluxDB when you select
-
-the field type is SeaTunnel field type `org.apache.seatunnel.api.table.type.SqlType`
+#### fields [Config]
Review Comment:
Maybe you need to check in detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1378172268
> > > cc @Hisoka-X @liugddx , could you help me review this PR?
> > > Let's wait for CI.
> > > I have resolved e2e module CI error , could you please restart CI ？thx
Hi, seem like you not update your code after resolved e2e module CI error. If you update the code, the ci will auto restart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1376762978
> cc @Hisoka-X @liugddx , could you help me review this PR?
Let's wait for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3897:
URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1384881231
Let's waiting CI process. Thanks, if CI passed this pull request can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org